Ticket #209 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

Add tests to cover partitioning using root on btrfs, xfs or other non-ext fstype's

Reported by: rhe Owned by: rhe
Priority: major Milestone: Fedora 16
Component: Wiki Version:
Keywords: 15 retrospective Cc: josef@…
Blocked By: Blocking:

Description

There are no tests to cover partitioning using non-ext file systems, such as btrfs/xfs etc. Tests need be added to cover these. Assign to me for now, feel free to retake it.

Change History

comment:1 follow-up: ↓ 2 Changed 3 years ago by adamwill

I believe someone mentioned on the list they were working on btrfs test cases, it may have been Athmane.

comment:2 in reply to: ↑ 1 Changed 3 years ago by athmane

Replying to adamwill:

I believe someone mentioned on the list they were working on btrfs test cases, it may have been Athmane.

No, it was John Dulaney

http://lists.fedoraproject.org/pipermail/test/2011-June/100749.html

comment:3 Changed 3 years ago by jlaska

When drafting this recommendation, the original intent was something to mimic the existing installer tests that create non-lvm primary partitions (e.g. https://fedoraproject.org/wiki/QA:Testcases_anaconda_ext4_rootfs_on_disk_partition). We may also want additional tests to more fully explore btrfs functionality. Let's get those into a different request if desired.

comment:4 follow-up: ↓ 5 Changed 3 years ago by jdulaney

James; I'd sort of been following that line of thought and using the EXT4 test cases as templates. I reckon I need to get back on this; I've been slacking.

Here's a couple of test cases: https://fedoraproject.org/wiki/User:Jdulaney/Draft_Testcase_btrfs_migration https://fedoraproject.org/wiki/User:Jdulaney/Draft_Testcase_Mount_btrfs

As I create more draft test cases, I'll link to them here as well as the mailing list.

I figure that the basic functionality ought to have priority; the replacement for logical volumes and other functionality is secondary to that.

comment:5 in reply to: ↑ 4 ; follow-up: ↓ 6 Changed 3 years ago by rhe

Hi jdulaney,

I remembered you created a btrfs test for installer:

https://fedoraproject.org/wiki/QA:Testcase_btrfs

Do you have any plan to update it? To make it mimic the non-lvm primary partitions(e.g. https://fedoraproject.org/wiki/QA:Testcases_anaconda_ext4_rootfs_on_disk_partition) or similar to the default partitioning install test(e.g. https://fedoraproject.org/wiki/QA:Testcase_Anaconda_autopart_install) ?

comment:6 in reply to: ↑ 5 ; follow-up: ↓ 7 Changed 3 years ago by jdulaney

Replying to rhe:

Hi jdulaney,

I remembered you created a btrfs test for installer:

https://fedoraproject.org/wiki/QA:Testcase_btrfs

Do you have any plan to update it? To make it mimic the non-lvm primary partitions(e.g. https://fedoraproject.org/wiki/QA:Testcases_anaconda_ext4_rootfs_on_disk_partition) or similar to the default partitioning install test(e.g. https://fedoraproject.org/wiki/QA:Testcase_Anaconda_autopart_install) ?

Actually, I have that written up in my notebook; just have to transfer it online. I plan to do so tomorrow. Today has been recover-from-yesterday-day.

I figure I'll get the Anaconda installation stuff done with, and I think that should cover a lot of the basic usage. Then I'll get into things such as subvolume creation/use, the LVM replacement stuff, etc.

comment:7 in reply to: ↑ 6 Changed 3 years ago by rhe

  • Cc josef@… added

Replying to jdulaney:

Replying to rhe:

Hi jdulaney,

I remembered you created a btrfs test for installer:

https://fedoraproject.org/wiki/QA:Testcase_btrfs

Do you have any plan to update it? To make it mimic the non-lvm primary partitions(e.g. https://fedoraproject.org/wiki/QA:Testcases_anaconda_ext4_rootfs_on_disk_partition) or similar to the default partitioning install test(e.g. https://fedoraproject.org/wiki/QA:Testcase_Anaconda_autopart_install) ?

Actually, I have that written up in my notebook; just have to transfer it online. I plan to do so tomorrow. Today has been recover-from-yesterday-day.

I figure I'll get the Anaconda installation stuff done with, and I think that should cover a lot of the basic usage. Then I'll get into things such as subvolume creation/use, the LVM replacement stuff, etc.

Thanks, I created a new anaconda btrfs test based on your test case:

where I assumed that only / was formatted as btrfs by anaconda defaults, but it surely need be confirmed by the developers. Adding Josef to the cc list. Josef, can you please clarify what's the default filesystem for /boot on Fedora 16? Also are there any other changes on anaconda when making btrfs as the default comparing with previous lvm defaults? Thanks.

comment:9 follow-up: ↓ 10 Changed 3 years ago by jdulaney

I've added a generic subvolume creation test (1). Next up is figuring out if Anaconda is going to support subvolume creation during install. If so, I'll creat a test case for that, as well.

I've also moved the test cases out of my user space, and catagorized them all together (2), including the Anaconda case.

(1) https://fedoraproject.org/wiki/QA:Testcase_btrfs_Subvolume_Creation (2) https://fedoraproject.org/wiki/Category:Btrfs_test_cases

comment:10 in reply to: ↑ 9 ; follow-up: ↓ 11 Changed 3 years ago by jlaska

Replying to jdulaney:

I've also moved the test cases out of my user space, and catagorized them all together (2), including the Anaconda case. (2) https://fedoraproject.org/wiki/Category:Btrfs_test_cases

Are these tests you'd envision someone running whenever btrfs-related packages are updated in bodhi? If so, in accordance with QA:SOP_package_test_plan_creation, perhaps it would make sense to use Category:Package_btrfs-progs_test_cases instead?

comment:11 in reply to: ↑ 10 Changed 3 years ago by jdulaney

Are these tests you'd envision someone running whenever btrfs-related packages are updated in bodhi? If so, in accordance with QA:SOP_package_test_plan_creation, perhaps it would make sense to use Category:Package_btrfs-progs_test_cases instead?

Indeed, I reckon I should do it that way. I'll fix it right fast.

comment:12 Changed 3 years ago by rhe

I updated the btrfs case as it's not yet set as default on Fedora 16:

comment:13 follow-up: ↓ 14 Changed 3 years ago by jdulaney

I've sent off some emails to see what is going on in that regard with btrfs (and Grub2, necessary for booting it).

If it is accepted (and I don't see how it would be without functional Grub2) as standard and Grub2 is not finished, then would Anaconda be able to do an Ext4 /boot partition automagically?

comment:14 in reply to: ↑ 13 Changed 3 years ago by rhe

Replying to jdulaney:

I've sent off some emails to see what is going on in that regard with btrfs (and Grub2, necessary for booting it).

If it is accepted (and I don't see how it would be without functional Grub2) as standard and Grub2 is not finished, then would Anaconda be able to do an Ext4 /boot partition automagically?

I know your concerning, but Looking up the F16BtrfsDefaultFs page, it still shows that the percentage of completion is 0%. The latest rawhide isos are uploaded at: http://serverbeach1.fedoraproject.org/pub/alt/stage/20110721-3/, and the default partitioning is still lvm. So I guess this feature will be finished on next version? Correct me if you got any surprise.

comment:15 Changed 3 years ago by rhe

Add the following btrfs and xfs partitioning tests to install test template:

These tests are set to the ‘Final’ priority according to the final release criteria:

"The installer must be able to create and install to any workable partition layout using any file system offered in a default installer configuration, LVM, software, hardware or BIOS RAID, or combination of the above"

If any other partitioning tests need be added to the template, feel free to discuss.

comment:16 Changed 3 years ago by rhe

  • Status changed from new to closed
  • Resolution set to fixed

Btrfs and xfs tests have been added to the install matrix.

Note: See TracTickets for help on using tickets.