#713 bodhi comments should be ordered by date
Closed: Fixed None Opened 15 years ago by pfrields.

In bodhi, comments seem to appear in somewhat random order:

https://admin.fedoraproject.org/updates/F9/pending/Miro-1.2.4-2.fc9,gnome-python2-extras-2.19.1-17.fc9

They should probably be ordered by date to avoid confusion, since sometimes bodhi comments do serve as a de facto discussion on an update.


lmacken: I have applied the following patch on our live instance: http://ricky.fedorapeople.org/0001-Sort-comments-by-date.patch

Comments should be properly sorted now - thanks for the report.

Hm, as an addition to that patch, maybe the line:
{{{
update.comments.sort(lambda x, y: cmp(x.timestamp, y.timestamp))
}}}
can be removed as well (line 798 in controllers.py).

Applied in bodhi changeset ed87efd530ef4abad474a3c021b2101818457a5b. Thanks for the patch, ricky!

Login to comment on this ticket.

Metadata