I'm trying to find the best way of marking releases of individual packages for the build purposes. Tags seem like a nice way of doing that, except they are not immutable, and changes done to them are not tracked anywhere (unlike changes to code).
Please consider doing
chmod +x spacewalk.git/hooks/update
and applying the following patch to the spacewalk.git/hooks/update file. It adds check for config option hooks.allowupdatetag and if it is not present, it will prevent tags from being modified once they landed in the public repository. In addition, hooks.allowdeletetag (also not set by default) will prevent tags from being removed.
The patch for the spacewalk.git/hooks/update file hooks-update.diff
attachment update-new.diff
I've made the changes, however the version of git on the hosted server is older than the one you used to create that patch so I applied the original patch to the update hook on a fresh git repo on my F-9 desktop and uploaded it to the hosted server. The original update hook was saved as update.orig. I've attached a diff of what used to be in the hosted spacewalk repo and what's there now.
Note sure if this is related but I'm now getting this error when attempting to push changes:
Counting objects: 5, done. Compressing objects: 100% (3/3), done. Writing objects: 100% (3/3), 399 bytes, done. Total 3 (delta 1), reused 0 (delta 0) *** Project description file hasn't been set error: hooks/update exited with error code 1 error: hook declined to update refs/heads/master To ssh://dgoodwin@git.fedorahosted.org/git/spacewalk.git ! [remote rejected] master -> master (hook declined) error: failed to push some refs to 'ssh://dgoodwin@git.fedorahosted.org/git/spacewalk.git'
I have confirmed other developers are getting rejected with the same error.
The update hook has this bit of code in it:
# check for no description projectdesc=$(sed -e '1q' "$GIT_DIR/description") if [ -z "$projectdesc" -o "$projectdesc" = "Unnamed repository; edit this file to name it for gitweb." ]; then echo "*** Project description file hasn't been set" >&2 exit 1 fi
I set the description to "Spacewalk is an open source Linux and Solaris systems management solution." That should hopefully fix it.
That did the trick, thanks!
Login to comment on this ticket.