About: http://fedoraproject.org/PackageReviewStatus/NEW.html
This useful page list all not-blocked package reviews.
It will be nice to also includes reviews if blocked by bugs which are ON_QA.
Explanation: when multiple packages are submitted in a dependency tree, as soon as one is approved, and package built and submitted for testing, other dependent package can be reviewed.
Example: 1312939: mongo-c-driver - Client library written in C for MongoDB (ON_QA) 1269056: php-pecl-mongodb - MongoDB driver for PHP (NEW, blocked by previous) * 1276834: php-mongodb - MongoDB driver library (NEW, blocked by previous)
Workaround: close the 1st review to unblock others (but as Bodhi change the bug status to MODIFIED, ON_QA, CLOSED, this is not very reliable)
For any folks interested in working on this:
The main script is in https://infrastructure.fedoraproject.org/cgit/ansible.git/tree/roles/review-stats/build/files/review-stats.py and runs hourly from cron.
Metadata Update from @kevin: - Issue tagged with: easyfix
Metadata Update from @kevin: - Issue priority set to: Waiting on Asignee
Metadata Update from @kevin: - Issue priority set to: Next Meeting (was: Waiting on Assignee)
Metadata Update from @kevin: - Issue priority set to: Waiting on Assignee (was: Next Meeting)
Is this still needed/wanted
I have rewritten from scratch the code that generates pages, see https://pagure.io/review_stats It is now a python app deployable through setuptools and can be run inside a virtualenv. It can also make use of python logging to provide error feedback through smtp and use bugzilla API keys to authenticate. It also fixes #5316 An example result is at https://mattia.fedorapeople.org/review_stats/
BTW the config file actually used should have better protection: it is quite simple for anyone who's in the fi-apprentice group to find and read it, user and password included...
@mattia nice would you mind moving your code to https://pagure.io/Fedora-Infra/review_stats. I have just created it and it will make it easier to find it in the Fedora-Infra namespace.
This commit should fix that --> https://infrastructure.fedoraproject.org/cgit/ansible.git/commit/?id=b232437
Done, code migrated. Thanks.
Are we ready to close this?
The new code I've shared in the repo is quite ready. A few nice to have things to add: - since the code is now deployable by setuptools, it would be nice to rewrite the ansible playbook to make use of this (and maybe run it in a virtualenv with pipenv) - add a smtp handler to python logger instead of rely on crontab email. What address could be the right place to send error logs? Or is there some Nagios plugin that can be alerted of errors? - generate a Bugzilla API key and use that instead of package-review username and password - make python logger to store run logs
I've been extremely busy in the past days and I cannot make any progress. In the next weekend I can work on it again, but I will need some supervision with ansible playbook changes. Of course, I don't have write access to nothing, so someone will have to do the final deployment.
So we have 2 choice for deployment, currently the static page is built on the sundries boxes then it is synced on the proxies where httpd serves the page.
We can : 1 . package the new app as an rpm and build it in the .infra tag (so that we don't have to get it to proper Fedora). Then install that rpm on the sundries 2. install the dependencies of the new app on the sundries and do a git clone of the repo on the box.
@mattia do you have any preference ? would you be interested into working on the deployment ? (I am happy to help )
@cverna I've set up a tracker in review_stats repository for its deployment. https://pagure.io/Fedora-Infra/review_stats/issue/2
I think we can close this ticket and #5316 here and eventually continue the discussion there.
Metadata Update from @cverna: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.