#4854 Review list is stalled
Closed: Fixed None Opened 8 years ago by remi.

= bug description =
http://fedoraproject.org/PackageReviewStatus/NEW.html is stalled (newest review is from July 30th)


sudo -u apache /usr/local/bin/review-stats.py -c /usr/local/share/review-stats/review-stats.cfg -t /usr/local/share/review-stats/templates -d /srv/web/review-stats/

{{{
Traceback (most recent call last):
File "/usr/local/bin/review-stats.py", line 636, in <module>
subs['new'] = report_new(**args)
File "/usr/local/bin/review-stats.py", line 601, in report_new
write_html(loader, 'bymonth.html', data, tmpdir, 'NEW.html')
File "/usr/local/bin/review-stats.py", line 323, in write_html
f.write(output.render())
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2018' in position 93274: ordinal not in range(128)
}}}

I don't know how to contribute to fedora-infrastructure repository but I found one issue in current checkout of review-stats. I see execution of review-stats.py needs merge substitution by index.html but merge subs is already removed sometime ago. We need to remove it from index.html also.

I have created a patch and checked locally and found review-stats.py is working fine now. Can this patch be committed upstream and update the review tracker pages?

I am not sure what you're seeing but I should have already fixed that code while I was at Flock. Maybe I didn't push something, though.

Working on getting that stuff actually deployed in infrastructure now.

Yep, I had unpushed changes on my laptop. Those are in the repo now but I have more work to do.

Should all be fixed now.

Login to comment on this ticket.

Metadata