#4700 SCM commits are not delivered
Closed: Fixed None Opened 9 years ago by jjelen.

= bug description =
I am subscribed for commit watch in pkgdb

https://admin.fedoraproject.org/pkgdb/package/openssh/
for all fedora versions, but the commits are delivered only to Main Contact or Package administrators (?).

= bug analysis =
I have got my last mail from 24.3. Later then I did some more commits (also today), but without any message. From outside it looks like working:
{{{
remote: Emitting a message to the fedmsg bus.
remote: * Publishing information for 5 commits
}}}

but it looks like broken inside.

= fix recommendation =
Send emails to watchers?


Notifications are not sent for your own actions unless you explicitly ask for it in FMN: https://apps.fedoraproject.org/notifications/

So what is the commit watch for on pkgdb?
It worked until ~ last week and then it stopped without any change from my side.

In fedmsg I have got also watch for packages that plautrba owns, so it should cover it also, but still not SCM messages.

Replying to [comment:2 jjelen]:

So what is the commit watch for on pkgdb?
It worked until ~ last week and then it stopped without any change from my side.

That is correct, because last week pkgdb stopped sending emails and instead all notifications are going through FMN:
https://lists.fedoraproject.org/pipermail/devel-announce/2015-March/001557.html

In fedmsg I have got also watch for packages that plautrba owns, so it should cover it also, but still not SCM messages.

The first question is of course, did plautrba make a commit recently on that package?
But, I know we fixed something for this recently for watch* ACLs but I do not know if that made it to prod already or not yet, so it might be this problem as well.

Sorry for the inconvenience and thanks for the report

Plautrba didn't but I did several commits, as I state in the report. But it should also cover rule "A particular user's packages".

It will be related to this change. I read that mail probably too fast. It would be great to have in pkgdb some message that it doesn't do anything or just remove it not to confuse users. Or to use the old stuff as interface to Notifications? It was pretty straightforward, unlike the difficult rules in Notification system ...

Replying to [comment:4 jjelen]:

Plautrba didn't but I did several commits, as I state in the report. But it should also cover rule "A particular user's packages".

And it does, but it also matches the rule Not: A particular user, which by default is your username, so that you do not get notifications for the actions you are doing.

Ok. This makes sense. But
- I don't have such a rule (or I don't see it).
- If it is here default/hidden it is again confusing

Thanks for clarification, but there is still stuff to do ...

Replying to [comment:6 jjelen]:

Ok. This makes sense. But
- I don't have such a rule (or I don't see it).

The rule itself is named A particular user, it has a red (purplish) or green icon next to it. By clicking on it you can enforce the rule to be true or false and by default it is false.

Note: this red/green button will be changing in the next release as it was found to be confusing: https://github.com/fedora-infra/fmn/issues/70#issuecomment-85113447 for a preview

  • If it is here default/hidden it is again confusing

Thanks for clarification, but there is still stuff to do ...

Please feel free to open a ticket on FMN if you find something confusing or uneasy, we are eager to improve things :)

Is there anything further we need to do here?

Or can this be closed?

I think it is clear for me now. Provided that FNM is working on some improvements UI, I think you can close this ticket.

@jjelen, you'll need to file RFE tickets explaining what you think should be changed. Here is a good place: https://github.com/fedora-infra/fmn/issues

Login to comment on this ticket.

Metadata