#1881 unused-fedora-patches works only for kernel.spec
Closed: Fixed None Opened 14 years ago by jkratoch.

= phenomenon =

{{{make unused-fedora-patches}}} will report on non-kernel .spec files all the patches as {{{Unapplied}}}.
Moreover {{{libstdc++-v3-python-common-prefix.patch}}} is reported as both {{{Unused}}} and {{{Unapplied}}} (because it contains a special character "{{{+}}}").

= reason =

{{{../common/Makefile.common}}} expects the .spec file uses {{{ApplyPatch}}} but {{{ApplyPatch}}} is a function defined only in {{{kernel.spec}}}.
The latter problem is because filenames are bareworded into an extended regular expression ({{{egrep}}}) pattern.

= recommendation =

Attached fix accepts both {{{ApplyPatch}}} and rpm-native {{{%patchXXX}}} notation.
Moreover it does not use extended regular expression so that "{{{+}}}" can be present in a filename.
(It also makes some more strict requirements on trailing characters/whitespaces.)


Login to comment on this ticket.

Metadata