#1590 fedorapeople: default user index page improvements
Closed: Fixed None Opened 14 years ago by till.

Currently the default index page for fedorapeople only contains a directory listing and a link called "home, that leads to the public_html root dir. It would be nice to have also a listing of the user's public git repositories their. Ideally everyone, but for the beginning a link to the appropriate page on gitweb (if there ise one) would help, too.

Also a link to the overview of all fedorapeople links and maybe every other personal webpage for a maintainer would be helpful (bodhi, fas, packagedb, community portal, blog, ...). If you point me to the source, I might provide a patch.


I think everything you want is in:

git://git.fedorahosted.org/git/fedora-web.git/

If that template is missing or anything let me know, we likely just never copied it over from the puppet repo.

Script for creating/updating gitweb repo list on fedorapeople
make-people-git.sh

Till,

In case it helps, I've attached the script used for creating/updating the gitweb repo list on fedorapeople. It's short and simple, but it might save you a few minutes and some keystrokes.

Btw. my initial idea was to have user specific git links in /srv/people/site/userdefs/HEADER.html, so this would need to have some more autogenerated magic.

https://git.fedorahosted.org/cgit/fedora-web.git/tree/fedorapeople.org/make-people-page.sh is the current script.

Can someone rebase the desired changes on this and I can get it pushed?

And here we go. Can someone please review?

Thanks.

vk

I went to go apply it to fedora-web, but then I realized that the copy there was just a copy, and we had somehow dropped this script/cron job on the actual server since we moved it from puppet to ansible. ;(

Re-set it up and folded your changes into it...

However, then I ran into some issues:

/usr/local/bin/make-people-page.sh: line 95: syntax error near unexpected token fi' /usr/local/bin/make-people-page.sh: line 95: fi'

Looks like there's some syntax issues around if and fi and such. Can you recheck?

Replying to [comment:7 kevin]:

I went to go apply it to fedora-web, but then I realized that the copy there was just a copy, and we had somehow dropped this script/cron job on the actual server since we moved it from puppet to ansible. ;(

Re-set it up and folded your changes into it...

However, then I ran into some issues:

/usr/local/bin/make-people-page.sh: line 95: syntax error near unexpected token fi' /usr/local/bin/make-people-page.sh: line 95: fi'

Looks like there's some syntax issues around if and fi and such. Can you recheck?

Hi Kevin,

Thanks for looking in to this.
Err, yeah - just remove that "fi" from line 95, that should fix the issue.

Thanks.

vk

nope. :)

Removing the fi on line 95 leads to:

{{{
make-people-page.sh: line 82: [: too many arguments
make-people-page.sh: line 88: [: too many arguments
make-people-page.sh: line 89: [: too many arguments
make-people-page.sh: line 82: [: too many arguments
make-people-page.sh: line 88: [: too many arguments
make-people-page.sh: line 89: [: too many arguments
make-people-page.sh: line 90: [: too many arguments
}}}

Please test.

Heh.
I have to print this and pin it on the wall in fornt of my desk:

{{{
I will always quote string variables in Bash
I will always quote string variables in Bash
I will always quote string variables in Bash
I will always quote string variables in Bash
I will always quote string variables in Bash
}}}

Attaching another patch.
Tested on fedorapeople.org with a huge oneliner, here is the output (just the table, wthout styles and stuff): https://vkaigoro.fedorapeople.org/fp_page.html

looks good. Applied.

Thanks for working on this. :)

Login to comment on this ticket.

Metadata