The original proposal (#72) described a badge to be awarded for providing karma for updates to Fedora N-2, where N is the latest GA release. Such releases are supported for one month past GA of a new version. The YAML attached to the ticket (attachment:tester-you-can-pry-it-from-my-cold-dead-hands.yml:ticket:72) was also written in that spirit: Fedora 17 was release N-2 in August 2013, with Fedora 19 being the newest GA release N since 2013-07-02 (the former already EOL by then).
What was committed in the end, however, deviates from the logic in the proposal: https://git.fedorahosted.org/cgit/badges.git/commit/rules/tester-you-can-pry-it-from-my-cold-dead-hands.yml?id=165f033ab2d8abf6bcd2b4d61e27a8690e813c2e
Instead of checking for release N-2 and updating the check on GA of new versions, the trigger checks for the oldest release still supported. These two conditions only happen to coincide in the one-month period mentioned above. At any other time, the trigger for this badge will be equivalent to the trigger for the "It still works!" badge. Later commits haven't changed the behaviour in that regard.
Two ways to deal with this problem: Change the description to match the trigger and accept the fact that it's almost the same as (and almost always awarded together with) the "It still works!" badge. Maybe retire one of them? Change the trigger to match the description and revoke erroneously awarded badges. With a good part of the 383 holders having been awarded this badge simply for testing updates to release N-1 (including me), this makes for a lot of consolation prizes.
I vote for option #2.
Thanks for looking into this. We'll need:
sinic, would you like to provide the patch to the yaml rule and update the wiki pages?
attachment dead-cold-hands.patch
Am I correct in assuming that there's no way to provide karma to updates once a version of Fedora is EOL? Then it should be sufficient to decrement the rule's version string (and change the comment, of course).
I can remove it from https://fedoraproject.org/wiki/End_of_life_SOP#Badges_tasks and add it to fedora-releases.txt in the infrastructure documents, sure.
I applied your patch to the rule -- it is live now. Thanks! https://git.fedorahosted.org/cgit/badges.git/commit/?id=f86a532d4505a92b4b8d9e40032746edb1eba038
I also revoked the badge from all the existing holders (since I don't have an easy way to distinguish who got it erroneously or not) and I awarded all those same people the consolation-prize badge.
Once you're done editing those two documents, can you comment back here and we can close the ticket?
Here's the full list of accounts that had changes:
attachment 0001-Update-cold-dead-hands-badge-on-GA-not-on-EOL.patch
Badges awarded between 2013-12-17 (Fedora 21 GA) and 2014-01-14 (Fedora 18 EOL) were legitimate. Too late now, I guess.
I've edited the wiki, but I don't have permission to push changes to infra-docs. I've attached another patch instead.
Replying to [comment:5 sinic]:
Oh, shoot. You're right. :(
Thanks! Applied here: http://infrastructure.fedoraproject.org/cgit/infra-docs.git/commit/?id=ca36b51b784666176e617f1bbc97fcb06c3b00f9
According to the doc we should change the testfile in badges, as F22 has been release. I'm attaching a patch, hope this is correct (I guess we don't need to update also the doc-file as this is just an example).
attachment 0001-Updated-tester-badge-rule-for-f22-release.patch
Thanks! Applied! https://git.fedorahosted.org/cgit/badges.git/commit/?id=b1aeb4e000338e20b9c1d63756aeff84fcd5b1c9
I've updated it for F22 (as F24 was released).
Replying to [comment:9 churchyard]:
But only in the public git, still need a sysadmin to push it forward, according to [http://infrastructure.fedoraproject.org/cgit/infra-docs.git/tree/fedora-releases.txt?id=ca36b51b784666176e617f1bbc97fcb06c3b00f9#n299 fedora-releases.txt].
(10:25:56) sayan: mhroncok: pushed the changes
Login to comment on this ticket.