Ticket #24 (closed defect: fixed)

Opened 6 years ago

Last modified 14 months ago

make distcheck fails on system-search.png

Reported by: cardoe@… Owned by: mso
Priority: blocker Milestone:
Component: echo-icon-theme Version: devel
Keywords: Cc:
Blocked By: Blocking:

Description

Using git 4e825a306642bee35151038d55629593b2c57f26 results in the following

make[2]: Entering directory `/home/doug/.icons/echo-icon-theme/base/echo-icon-theme-0.3.89.0/_build/256x256' Making all in actions make[3]: Entering directory `/home/doug/.icons/echo-icon-theme/base/echo-icon-theme-0.3.89.0/_build/256x256/actions' make[3]: * No rule to make target system-search.png', needed by all-am'. Stop. make[3]: Leaving directory `/home/doug/.icons/echo-icon-theme/base/echo-icon-theme-0.3.89.0/_build/256x256/actions' make[2]: * [all-recursive] Error 1 make[2]: Leaving directory `/home/doug/.icons/echo-icon-theme/base/echo-icon-theme-0.3.89.0/_build/256x256' make[1]: * [all-recursive] Error 1 make[1]: Leaving directory `/home/doug/.icons/echo-icon-theme/base/echo-icon-theme-0.3.89.0/_build' make: * [distcheck] Error 2

Change History

comment:1 Changed 6 years ago by cardoe@…

make[2]: Entering directory `/home/doug/.icons/echo-icon-theme/base/echo-icon-theme-0.3.89.0/_build/256x256'
Making all in actions
make[3]: Entering directory `/home/doug/.icons/echo-icon-theme/base/echo-icon-theme-0.3.89.0/_build/256x256/actions'
make[3]: *** No rule to make target `system-search.png', needed by `all-am'.  Stop.
make[3]: Leaving directory `/home/doug/.icons/echo-icon-theme/base/echo-icon-theme-0.3.89.0/_build/256x256/actions'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/doug/.icons/echo-icon-theme/base/echo-icon-theme-0.3.89.0/_build/256x256'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/doug/.icons/echo-icon-theme/base/echo-icon-theme-0.3.89.0/_build'
make: *** [distcheck] Error 2

comment:2 Changed 6 years ago by mso

  • Owner changed from luya, mso to mso
  • Milestone set to 0.4
  • Priority changed from major to blocker
  • Status changed from new to assigned

Aaah, I forgot to fill the EXTRA_DIST variable in 256x256/Actions/Makefile.am in yesterdays commit. I'll verify if the fix I prepared pass the make distcheck and upload the changes to git then. Thanks for notifying us :-)

comment:3 Changed 6 years ago by mso

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:4 Changed 6 years ago by anonymous

Thanks for the fast reply. The master branch icon theme can now be found in Gentoo as x11-themes/echo-icon-theme. I'll be doing regular snaps.

comment:5 Changed 6 years ago by mso

Aah, that's great. Just a note, that I've changed fallback theme to Fedora icon theme, so you'll need to patch it in Gentoo to something else (like gnome or Mist). The reason behind this switch is to pick up Fedora logo, but it would be perhaps better to have the upstream fallback to 'gnome' and patch it in fedora instead... I'll think about it a little more ;-)

comment:6 Changed 14 months ago by mso

  • Milestone 0.4 deleted

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.