Timeline


and

03/26/14:

04:44 Changeset [abd12cb] by Luke Macken <lmacken@…>
develop
  • bodhi.spec
  • bodhi/release.py
  • bodhi/tools/client.py
  • bodhi/modifyrepo.py

Merge branch 'release/0.9.9.1' into develop

04:44 Changeset [ef77d35] by Luke Macken <lmacken@…>
master
  • bodhi.spec
  • bodhi/release.py
  • bodhi/tools/client.py

Merge branch 'release/0.9.9.1'

04:43 Changeset [043c26f] by Luke Macken <lmacken@…>
masterdevelop
  • bodhi.spec
  • bodhi/release.py
  • bodhi/tools/client.py

Bump version to 0.9.9.1

04:41 Changeset [b3d6371] by Luke Macken <lmacken@…>
develop
  • bodhi/modifyrepo.py

Merge pull request #43 from fedora-infra/feature/sha1-on-el5

Use sha1 instead sha256 for our updateinfo.xml checksum on el5

03/25/14:

20:26 Changeset [9107c4f] by Luke Macken <lmacken@…>
developfeature/sha1-on-el5
  • bodhi/modifyrepo.py

Use sha1 instead sha256 for our updateinfo.xml checksum on el5 (#1080373)

Yum on Python2.4 supports the sha256 checksum type only if python-hashlib is
available, but there is not a hard requirement on it.

03/24/14:

17:33 Ticket #749 (tomcat-7.0.33-3.el6 won't start) closed by kevin
invalid: This isn't a bodhi issue... please file a bug against tomcat: …
10:05 Ticket #750 (On home page of web UI, search box is not working properly.) created by amsharma
Type any package name for example 389-ds-base in the search box i.e. …

03/20/14:

17:12 Ticket #749 (tomcat-7.0.33-3.el6 won't start) created by kakbit
Hi, I installed EPEL tomcat-7.0.33-3.el6.noarch on CentOS 6.5 but it …

03/19/14:

16:04 Ticket #748 (fedpkg new-sources SSL connect error) closed by lmacken
invalid: Yeah, this isn't a bodhi issue. Please re-file it in the …
06:37 Ticket #748 (fedpkg new-sources SSL connect error) created by nathans
Hi there! Following the bog standard package updating recipe that I …
00:23 Ticket #649 (Push fails when update headed for testing reaches stable karma before push ...) closed by lmacken
fixed: Bodhi 0.9.9 has just be deployed to production, which should resolve this …
00:22 Ticket #388 (Bodhi should (offer to) reset karma when submitting new builds in an ...) closed by lmacken
fixed: Bodhi 0.9.9 has just be deployed to production. Please re-open this ticket …

03/14/14:

22:02 Changeset [8669776] by Luke Macken <lmacken@…>
masterdevelopfeature/sha1-on-el5
  • bodhi.spec
  • bodhi/release.py
  • bodhi/tools/client.py

Merge branch 'release/0.9.9' into develop

22:02 Changeset [d9206df] by Luke Macken <lmacken@…>
masterhotfix/0.9.9.0.1
  • bodhi.spec
  • bodhi/admin.py
  • bodhi/buildsys.py
  • bodhi/closure.py
  • bodhi/config/app.cfg
  • bodhi/controllers.py
  • bodhi/identity/sobzprovider.py
  • bodhi/identity/tables.py
  • bodhi/jobs.py
  • bodhi/json.py
  • bodhi/mail.py
  • bodhi/masher.py
  • bodhi/metadata.py
  • bodhi/metrics.py
  • bodhi/model.py
  • bodhi/modifyrepo.py
  • bodhi/overrides.py
  • bodhi/release.py
  • bodhi/rss.py
  • bodhi/search.py
  • bodhi/tests/test_controllers.py
  • bodhi/tests/test_metadata.py
  • bodhi/tests/test_model.py
  • bodhi/tests/test_util.py
  • bodhi/tools/0day.py
  • bodhi/tools/clean-stable.py
  • bodhi/tools/clean-testing.py
  • bodhi/tools/client.py
  • bodhi/tools/close_neglected_bugs.py
  • bodhi/tools/fix_dupe_ids.py
  • bodhi/tools/log_stats.py
  • bodhi/tools/metrics.py
  • bodhi/tools/pickledb.py
  • bodhi/util.py
  • bodhi/validators.py
  • bodhi/widgets.py
  • setup.py

Merge branch 'release/0.9.9'

21:57 Changeset [923fab7] by Luke Macken <lmacken@…>
masterdevelopfeature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi.spec
  • bodhi/release.py
  • bodhi/tools/client.py

Bump version to 0.9.9

18:10 Changeset [95848f9] by Luke Macken <lmacken@…>
masterdevelopfeature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/config/app.cfg
  • bodhi/model.py
  • bodhi/tests/test_model.py

Merge pull request #41 from fedora-infra/feature/issue-36

Disable karma automatism on AutoQA test failures (fixes #36)

03/13/14:

17:57 Changeset [db6c2f0] by Luke Macken <lmacken@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/config/app.cfg
  • bodhi/model.py
  • bodhi/tests/test_model.py

Disable karma automatism on AutoQA test failures (fixes #36)

03/12/14:

14:58 Changeset [3a3cc31] by Luke Macken <lmacken@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/masher.py
  • bodhi/metadata.py
  • bodhi/modifyrepo.py
  • bodhi/tests/test_controllers.py
  • bodhi/tests/test_metadata.py
  • bodhi/mail.py
  • bodhi/model.py

Merge pull request #35 from bochecha/updateinfo

Prefix the updateinfo file with its hash

14:54 Changeset [5df9685] by Luke Macken <lmacken@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/mail.py
  • bodhi/model.py

Merge pull request #38 from bochecha/changelog

Fix changelog handling

11:51 Changeset [66e9f90] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/tests/test_controllers.py

tests: Add a message on the assertion error

This assertion was failing due to a syntax error in my masher/updateinfo
code.

Adding this message allowed me to find it quickly, and it could be
useful in the future.

11:51 Changeset [8193e7c5] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/tests/test_metadata.py

tests: Teach the metadata tests about the new updateinfo name

11:51 Changeset [6a45da5] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/masher.py

masher: Find the old updateinfo files

Now that we prefix the updateinfo metadata with its hash, the Bodhi
masher must be taught to find it.

The bonus point of using a glob is that it even handles migration from
non-prefixed to prefixed file name. :)

04:24 Changeset [6488e29] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/mail.py
  • bodhi/model.py

Fix changelog handling

The RPM API does not seem to always return a list for the changelog
timestamp(s).

Bodhi has some code trying to identify that and treat it accordingly.

However, it was based on the identified cases where this happened (there
is only one changelog text) instead of just being based on whether or
not the changelog was a list.

It seems that this behaviour in the RPM Python API, as I'm now seeing
cases where Bodhi thinks the timestamp is not in a list, when it
actually is.

This commit fixes this.

03/04/14:

09:50 Changeset [146f35e] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/modifyrepo.py

updateinfo: Prefix the file name with its hash

This is similar to what is done with other Yum repository metadata.

It is not just about consistency though, it fixes real issues.

For example, at work, we use the Amazon CDN to implement mirroring of
our Yum repositories. All files are cached on the CDN for the default
duration (i think it's 24 hours), except repomd.xml which is never
cached.

This works great for RPMS (they never change once published) and all
the metadata files (their names are prefixed with their hash, and as
such the CDN sees them as different files).

However, we keep running into trouble with updateinfo.xml.gz: the CDN
keeps distributing the old file even though a new one was generated.

Because the updateinfo metadata can be quite big, we'd rather prefix
its name with a hash (like other Yum repository metadata), and let the
CDN handle it, rather than telling the CDN to never cache it, which
would put more load on our primary repository server.

09:50 Changeset [213179a] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/modifyrepo.py

updateinfo: While we're at it, move to sha256

All other Yum repository metadata are already using this stronger hash,
so let's be consistent and more secure.

09:50 Changeset [2a6fc20] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/modifyrepo.py

updateinfo: Remove misleading comments

If someone tries to uncomment these for debugging purpose, they might
not realize that they don't reflect reality any more, and might waste
lots of time trying to figure out what is going on.

09:50 Changeset [37ac331] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/metadata.py

updateinfo: Remove previous cached updateinfo

Now that we prefix the file name with its hash, each written file will
have a different name.

As a result, we need to remove the previous versions when we load it,
otherwise we end up accumulating updateinfo.xml.gz metadata files.

03/03/14:

16:45 Changeset [d6b012e] by Luke Macken <lmacken@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/admin.py
  • bodhi/buildsys.py
  • bodhi/closure.py
  • bodhi/controllers.py
  • bodhi/identity/sobzprovider.py
  • bodhi/identity/tables.py
  • bodhi/jobs.py
  • bodhi/json.py
  • bodhi/mail.py
  • bodhi/metadata.py
  • bodhi/metrics.py
  • bodhi/model.py
  • bodhi/modifyrepo.py
  • bodhi/overrides.py
  • bodhi/rss.py
  • bodhi/search.py
  • bodhi/tests/test_controllers.py
  • bodhi/tests/test_model.py
  • bodhi/tests/test_util.py
  • bodhi/tools/0day.py
  • bodhi/tools/clean-stable.py
  • bodhi/tools/clean-testing.py
  • bodhi/tools/client.py
  • bodhi/tools/close_neglected_bugs.py
  • bodhi/tools/fix_dupe_ids.py
  • bodhi/tools/log_stats.py
  • bodhi/tools/metrics.py
  • bodhi/tools/pickledb.py
  • bodhi/util.py
  • bodhi/validators.py
  • bodhi/widgets.py
  • setup.py

Merge pull request #34 from bochecha/pep8

A couple of PEP 8 fixes

08:48 Changeset [6c7e153] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/mail.py
  • bodhi/tools/clean-testing.py

PEP8: Indentation by multiples of 4 (E111)

08:48 Changeset [0b1dd80] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/model.py
  • bodhi/util.py

PEP8: Only one space after operators (E222)

08:48 Changeset [47ab2b0] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/mail.py
  • bodhi/tests/test_controllers.py
  • bodhi/widgets.py

PEP8: Closing brackets to match indentation (E124)

08:48 Changeset [a509f3f] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/tests/test_controllers.py

PEP8: Use 'is' for boolean comparisons (E712)

There are 4 other occurences of this error, but we can't fix them
unfortunately.

They appear in some SQLObject queries, for example:

PackageUpdate?.select(PackageUpdate?.q.pushed == True)

Replacing the "==" comparison by a "is" changes the queries, and they
actually start silently failing.

08:48 Changeset [a8f1df4] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/controllers.py
  • bodhi/jobs.py
  • bodhi/rss.py

PEP8: Continuation intentation by multiples of 4 (E121)

08:48 Changeset [92f39eb] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/controllers.py
  • bodhi/model.py
  • bodhi/tools/metrics.py

PEP8: Distinguish continuation lines from indented block (E125)

08:48 Changeset [11cddf1] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/model.py
  • bodhi/tests/test_controllers.py
  • bodhi/tools/clean-stable.py
  • bodhi/tools/fix_dupe_ids.py
  • bodhi/tools/log_stats.py
  • bodhi/util.py

PEP8: Don't use too much blank lines (E303)

08:48 Changeset [4f6fbef] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/util.py

PEP8: Add some missing whitespace (E301)

08:48 Changeset [82986b0] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/controllers.py
  • bodhi/model.py
  • bodhi/tools/client.py

PEP8: Reindent continuation lines (E122)

08:48 Changeset [8c5d951] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/buildsys.py
  • bodhi/json.py
  • bodhi/metadata.py
  • bodhi/model.py
  • bodhi/modifyrepo.py
  • bodhi/search.py
  • bodhi/tests/test_controllers.py
  • bodhi/validators.py
  • bodhi/widgets.py

PEP8: Drop space around brackets (E201 and E202)

This drops the whitespace after an opening bracket and the whitespace
before a closing bracket.

08:48 Changeset [bc34531] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/admin.py
  • bodhi/buildsys.py
  • bodhi/controllers.py
  • bodhi/model.py
  • bodhi/overrides.py
  • bodhi/tools/client.py

PEP8: Don't over-indent continuation lines (E127)

08:48 Changeset [14e887f] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/controllers.py

Don't evaluate the same condition twice

These two lines evaluate equivalent conditions:

elif tg_errors.has_key('captcha'):

if 'captcha' in tg_errors:

Therefore, having them one after the other is useless: the second one
will always be True if the first one was.

That means we can use only one fo them, reindent the whole block, and
drop the condition which will always be False:

elif tg_errors.has_key('captcha'):

if 'captcha' in tg_errors:

...

else:

# This can never be True

08:48 Changeset [3b823c5] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/controllers.py

Drop useless condition

We can never go through that block, because if tg_errors does have a
'author' key, then we'd have been through the previous one, and we
wouldn't have checked whether it had a 'captcha' key.

08:48 Changeset [44e04d3] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/controllers.py
  • bodhi/jobs.py
  • bodhi/metrics.py
  • bodhi/model.py
  • bodhi/tests/test_model.py
  • bodhi/tools/client.py
  • bodhi/tools/pickledb.py

PEP8: Stop using the deprecated .has_key() (W601)

08:48 Changeset [7d0c64f] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/model.py
  • bodhi/tests/test_controllers.py
  • bodhi/tests/test_model.py

PEP8: Use is for comparisons to None (E711)

Many of these could not be fixed, as they appear in SQLObject queries,
where using is instead of == breaks the filtering.

08:48 Changeset [1762944] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/controllers.py

PEP8: Fix closing bracket indent (E123)

08:48 Changeset [971fabc] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/controllers.py
  • bodhi/jobs.py
  • bodhi/metrics.py
  • bodhi/model.py
  • bodhi/overrides.py
  • bodhi/search.py
  • bodhi/tests/test_model.py
  • bodhi/tools/clean-stable.py
  • bodhi/tools/metrics.py
  • bodhi/util.py

PEP8: At least two spaces before inline comments (E261)

08:48 Changeset [b0b56c2] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/buildsys.py

Fix typo

08:48 Changeset [09cc719] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/admin.py
  • bodhi/buildsys.py
  • bodhi/closure.py
  • bodhi/controllers.py
  • bodhi/jobs.py
  • bodhi/metrics.py
  • bodhi/model.py
  • bodhi/tests/test_controllers.py
  • bodhi/tests/test_model.py
  • bodhi/tools/client.py
  • bodhi/util.py

PEP8: Add missing whitespace after ',' (E231)

08:48 Changeset [99b60a8] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/closure.py
  • bodhi/identity/tables.py
  • bodhi/mail.py
  • bodhi/metrics.py
  • bodhi/modifyrepo.py
  • bodhi/overrides.py
  • bodhi/rss.py
  • bodhi/search.py
  • bodhi/tests/test_model.py
  • bodhi/tests/test_util.py
  • bodhi/tools/pickledb.py

PEP8: Remove trailing whitespaces (W291)

08:48 Changeset [8c0173b] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/closure.py
  • bodhi/controllers.py
  • bodhi/identity/sobzprovider.py
  • bodhi/model.py
  • bodhi/tools/metrics.py
  • setup.py

PEP8: Add whitespace around operators (E225)

08:48 Changeset [8e94f27] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/tools/close_neglected_bugs.py

PEP8: One statement per line (E702)

08:48 Changeset [63e00015] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/tools/0day.py

PEP8: No blank line at end of files (W391)

08:48 Changeset [948a1b4] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/modifyrepo.py

PEP8: Raise exceptions the correct way (W602)

08:48 Changeset [8673485] by Mathieu Bridon <bochecha@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/rss.py

PEP8: Remove redundant backslashes (E502)

03/01/14:

01:00 Changeset [981ef4b] by Luke Macken <lmacken@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/tests/test_controllers.py

Revert "Drastically speed up our tests by only starting TG once."

This reverts commit 552c05a03ccfef234ffb8a6e52087ef316ead814 until we can
figure out how to get it working on EPEL6.

00:59 Changeset [4fe2850] by Luke Macken <lmacken@…>
feature/inherit-builds
  • bodhi/tests/test_controllers.py

Revert "Drastically speed up our tests by only starting TG once."

This reverts commit 552c05a03ccfef234ffb8a6e52087ef316ead814 until we can
figure out how to get it working on EPEL6.

00:57 Changeset [bc5858e] by Luke Macken <lmacken@…>
feature/inherit-builds
  • bodhi/tests/test_controllers.py

Update the test_obsoleting_multibuild_update for the new obsoletion behavior

00:57 Changeset [d29cc45] by Luke Macken <lmacken@…>
feature/inherit-builds
  • bodhi/tests/test_controllers.py

Update the test_obsoleting_different_batches_of_updates test

00:57 Changeset [a6200db] by Luke Macken <lmacken@…>
feature/inherit-builds
  • bodhi/tests/test_controllers.py

Fix the test_add_older_build_to_update docstring

00:57 Changeset [b7acb87] by Luke Macken <lmacken@…>
feature/inherit-builds
  • bodhi/tests/test_controllers.py

Tweak a couple more unit tests

00:57 Changeset [150d264] by Luke Macken <lmacken@…>
feature/inherit-builds
  • bodhi/controllers.py

If we're inheriting builds from a security update, inherit the type

00:57 Changeset [9f8a1fa5] by Luke Macken <lmacken@…>
feature/inherit-builds
  • bodhi/controllers.py

Improvements to the auto-obsoletion behavior.

This allows new updates to obsolete any updates containing older versions,
along with builds for packages not present in the new update. These non-obsolete
builds are then inherited into the new update.

02/28/14:

16:33 Changeset [cb9e048] by Luke Macken <lmacken@…>
masterdevelopfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/model.py
  • bodhi/tests/test_controllers.py

Merge pull request #32 from fedora-infra/feature/stablekarma-push-race

Fix the stablekarma-during-push race condition bug

01:41 Changeset [552c05a] by Luke Macken <lmacken@…>
masterdevelopfeature/inherit-buildsfeature/issue-36feature/sha1-on-el5hotfix/0.9.9.0.1
  • bodhi/tests/test_controllers.py

Drastically speed up our tests by only starting TG once.

00:54 Changeset [b630e31] by Luke Macken <lmacken@…>
masterdevelopfeature/issue-36feature/sha1-on-el5feature/stablekarma-push-racehotfix/0.9.9.0.1
  • bodhi/tests/test_controllers.py

Add an autokarma push race unit test

00:54 Changeset [7650875] by Luke Macken <lmacken@…>
masterdevelopfeature/issue-36feature/sha1-on-el5feature/stablekarma-push-racehotfix/0.9.9.0.1
  • bodhi/model.py

Don't trigger the stablekarma threshold if the update is being pushed (#649)

https://fedorahosted.org/bodhi/ticket/649

Note: See TracTimeline for information about the timeline view.