Ticket #396 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

automatic karma magic half re-enables itself

Reported by: till Owned by:
Priority: critical Milestone:
Component: bodhi-server Version:
Keywords: Cc: thoger
Blocked By: Blocking:

Description

If auto-karma is disabled and the updated edited again, the next submit will fail with an error that the stable karma needs to be at least 1 and the checkbox for auto karma is checked again. This may lead to unexpected enabling of auto-karma.

Change History

comment:1 Changed 4 years ago by thoger

  • Cc thoger added

Any progress here or with ticket #353, which seems to be for the same problem?

comment:2 Changed 4 years ago by till

The attached patch should make bodhi check the karma thresholds only when the checkbox is selected and therefore fix this problem. I cannot test the patch, because a local "make run" bodhi seems not to allow saving edited updates. :-/

comment:3 Changed 4 years ago by lmacken

  • Status changed from new to closed
  • Resolution set to fixed

Patch applied in 6c7f4e5d428b409743fe462eb16e8df1f25ed277 -- Thanks!

Note: See TracTickets for help on using tickets.