Ticket #258 (closed enhancement: fixed)

Opened 6 years ago

Last modified 5 years ago

implement 'make test'

Reported by: kparal Owned by: tflink
Priority: minor Milestone: 0.5.0
Component: documentation Keywords:
Cc: Blocked By:


Some of our modules have unit tests. Let's execute them all by "make test" command and report the result. We can use this functionality to periodically check whether nothing got broken.

Change History

comment:1 Changed 6 years ago by kparal

mkrizek tried to implement this, his code is in the 'maketest' branch

comment:2 Changed 5 years ago by jlaska

Tim ... does this ticket fall into the unittest and py.test work you are doing?

comment:3 Changed 5 years ago by tflink

  • Owner set to tflink
  • Status changed from new to assigned

Yeah, eventually I want to get everything integrated with 'make test'

comment:4 Changed 5 years ago by kparal

  • Priority changed from major to minor

We prefer to have the plumbing/framework in place for 0.5.0 with some basic tests (or existing tests) implemented. That does not include large refactoring of existing classes (that can come later).

comment:5 Changed 5 years ago by kparal

  • Milestone changed from 0.5.0 to Nice to have soon

comment:6 Changed 5 years ago by tflink

I wasn't planning to do this now, but ended up writing a bunch of tests for #314 and have an initial form of 'make test' in the tflink branch -df3d9cb12df3f6324eb9c7d9005c5eb7a6263f02

I recycled a lot of stuff from the proof-of-concept that I did earlier but without the disruptive refactoring.

You still need to have python-pip and python-virtualenv installed in order for this to work. The first time that you run this, it will take a while as it downloads dependencies.

comment:7 Changed 5 years ago by tflink

  • Status changed from assigned to closed
  • Resolution set to fixed

Initial code has been reviewed and pushed to master


This still doesn't execute all of the unit tests, though

comment:8 Changed 5 years ago by kparal

  • Milestone changed from Nice to have soon to 0.5.0

Tim, I currently don't know exactly which unit tests we have but don't execute them, and whether they are available in master or just in maketest branch. Could you please file a new fingerfood(?) ticket about integrating those remaining unit tests into our new test framework (re-writing them if necessary), and make a list of them there? Thanks.

comment:9 Changed 5 years ago by kparal

  • Component changed from core to documentation

One more thing, maybe we would like to document this behavior in our development process somewhere on wiki. Changing to documentation component until we do that.

comment:10 Changed 5 years ago by tflink

  • Status changed from closed to reopened
  • Resolution fixed deleted

#340 was created to integrate depcheck tests into the main test suite. They might need refactoring to make them more useful but at least we have a ticket to keep track of them.

Also, re-opening since documentation still isn't done.

comment:11 Changed 5 years ago by tflink

Initial documentation is up on the wiki:


It doesn't feel quite done to me yet, I'm planning to go over it again next week before moving it to a more permanent page (not sandbox).

comment:13 Changed 5 years ago by tflink

  • Status changed from reopened to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.