Ticket #248 (assigned task)
depcheck: simultaneous run may report incorrect results
|Reported by:||kparal||Owned by:||wwoods|
This is taken from:
I have imagined a situation where two updates are accepted into the -pending tag in quick succession. Thus we can end up with two depcheck tests running simultaneously. And the one that was started earlier can finish up later. It could then report incorrect result.
Do you have an idea what we can we do about that? Maybe we can somehow write down the state of the -pending tag in the time of starting the test, and if it is different from when the test is finished, we can just throw away the results? Just a wild idea.
Wwoods mentioned that he's working on --accepted option for depcheck, here is short IRC excerpt, hopefully he will provide more info soon:
(05:16:13 PM) wwoods: I'm working on a mailing list post about the "accepted" flag (05:19:13 PM) wwoods: the short answer is this: we mark packages as "accepted" when they pass depcheck (05:19:48 PM) wwoods: exactly *how* we mark the package is kind of an implementation detail - could be a koji tag or a local database of accepted package names or whatever (05:20:04 PM) wwoods: but since we're already planning to give +1 karma for packages that are accepted (05:21:02 PM) wwoods: then we can (I hope!) just check Bodhi for each thing in -pending (05:21:11 PM) wwoods: if it has +1, it was previously accepted (05:21:21 PM) wwoods: err - has a +1 from autoqa / depcheck (05:21:51 PM) wwoods: in the future we might want to query resultsdb instead, or use a second koji tag (05:22:39 PM) wwoods: I'll still write a (possibly longer) explanation for the list - or maybe a blog post