Ticket #205 (closed enhancement: fixed)

Opened 4 years ago

Last modified 3 years ago

Provide a support for sending comments into Bodhi

Reported by: wwoods Owned by:
Priority: major Milestone: 0.4.4
Component: core Keywords:
Cc: lmacken Blocked By:
Blocking:

Description (last modified by kparal) (diff)

We need to be able to post comments into Bodhi. Comments should probably include test name, test result, URL to full results, karma and should be reported from 'autoqa' user.

We should somehow tackle the issue of comment duplication, as discussed here:
https://fedorahosted.org/pipermail/autoqa-devel/2010-November/001309.html

This should be implemented as a library method so a particular test can call it (for now, we will design better solution in the future).

Change History

comment:1 Changed 4 years ago by wwoods

This will probably work similarly to the way rats_{install,sanity}.py use irb.conf - there will need to be a private configuration file that contains the autoqa username/password, which the test can use to submit karma.

This information cannot be put in the system-wide autoqa config, because that shows up in the logs in plaintext, and we really don't want to expose the autoqa password to the world.

comment:2 Changed 4 years ago by jlaska

  • Milestone changed from Package Update Acceptance Test Plan - depcheck to Package Update Acceptance Test Plan

Per discussion at recent autoqa-devel meeting, moving out of depcheck milestone and into generic Package Update Acceptance Test Plan milestone. The lessons learned in this ticket will apply to the entire test plan, not just the depcheck test case.

comment:3 Changed 3 years ago by lmacken

  • Cc lmacken added

comment:4 Changed 3 years ago by kparal

  • Milestone changed from Package Update Acceptance Test Plan to 0.4.4

comment:5 Changed 3 years ago by kparal

  • Summary changed from make depcheck submit karma/comments to bodhi to Provide a support for sending comments into Bodhi
  • Description modified (diff)
  • Type changed from task to enhancement
  • Owner set to mkrizek

comment:6 Changed 3 years ago by kparal

  • Component changed from tests to core

comment:7 Changed 3 years ago by kparal

After discussion with wwoods, we seem to be missing one more requirement in our current code - test architecture. Upgradepath is a noarch test, which means it is enough to send just one result into Bodhi. But for arch-dependent test (like depcheck), we need to provide result for every architecture. That means that our send-bodhi-comment methods must support providing an architecture (and also need to be able to query for it). More happy coding for mkrizek... :-)

comment:8 Changed 3 years ago by kparal

Patch has been sent for review. According to the discussion we want to alter a few more things:

  1. Make BODHI_POSTING_COMMENT_SPAN configurable in autoqa.conf.
  2. get_cfg() should support accepting a list of alternative config file locations.
  3. autoqa script should use get_cfg() itself (and also look for other code that could be converted to get_cfg() usage).
  4. Staging Bodhi server can be used for testing this patch in a larger scope.

comment:9 Changed 3 years ago by kparal

  • Owner mkrizek deleted
  • Component changed from core to documentation

This ticket has been solved by commit 5d37e59128c1913946c02e6a1d899a5576f37801. Thanks, mkrizek!

Changing component to documentation, we certainly need to document these changes.

comment:10 Changed 3 years ago by kparal

  • Status changed from new to closed
  • Resolution set to fixed
  • Component changed from documentation to core
Note: See TracTickets for help on using tickets.