#63 run "phpci" on php package
Closed: Fixed None Opened 11 years ago by remi.

php-bartlett-PHP-CompatInfo provides a lot of useful report for reviewer of PHP package (library or webapp)

Should be really interesting :

$ phpci print --recursive --report summary /path/to/sources

$ phpci print --recursive --report extension /path/to/sources

$ phpci print --recursive --report class /path/to/sources


Using current plugin API, this could probably be implemented as a python or perhaps even a bash plugin.

Hm... If I created a simple plugin doing this, could you test it?

Attaching a plugin. Just drop it in ~/.local/share/fedora-review/scripts dir to test (with 755 permissions).

The phpci command is probably not that ideal... but I guess you are in a better position to fix that :) I have only made a basic test that it runs, no corner-case testing at all.

BTW: testing procedure:
- Download a src rpm like php-whatever.src.rpm
- Run it first time: ./try-fedora-review -rn php-whatever.src.rpm (slow)
- Run it next time(s): ./try-fedora-review -rn php-whatever.src.rpm --no-build (fast).

Thanks for the plugin draft.

Improved version attached.

  • FR_NAME is not usable, as most package use something different
  • improved options

Damned, I saw it (FR_NAME) after attaching but didn't realize you would run into it at once. Sorry for the mess.

Thanks for testing. Will add it to distribution, but package it separately to avoid a default dependency on the complete php stuff.

Fixed in 3c1fe91. Thanks for report and debugging :)

Login to comment on this ticket.

Metadata