#248 Compatibility with phpcompatinfo v4
Closed: Fixed None Opened 9 years ago by remi.

Hi,

For now we have
php-bartlett-PHP-CompatInfo 2.26 in Fedora 20 and EPEL
php-bartlett-PHP-CompatInfo 3.7.3 in Fedora 21+

In upcoming version 4.0.0 (beta3 released, RC next week, stable soon) the command options have change again, and the launcher need to be adapted again :(

See attached patch


Another idea, which can make things simpler in the future (if command syntax change again...):

{{{
if [ -x /usr/share/php-bartlett-PHP-CompatInfo/fedora-review-check ]
then
/usr/share/php-bartlett-PHP-CompatInfo/fedora-review-check $LOG $PWD/BUILD/*

elif ...

}}}

And of course, I will add the fedora-review-check shell script in the php-bartlett-PHP-CompatInfo with the correct arg. according to the current version.

The second patch "0001-adapt-PHP-plugin-for-upcoming-phpcompatingo-v4.patch​" implement idea from previous comment.

Please, use the one you prefer.

fedora-review-check script added in https://github.com/remicollet/remirepo/commit/c090eb65698dc2d9be14553ef9b504f649d3ade2

Can you please have a look to lastest patch, phpcompatinfo 4.0.0 is released (blocked by new dep. review, but should be soon in Fedora)

Merged the second "0001-adapt-PHP-plugin-for-upcoming-phpcompatingo-v4.patch​" in bd45812

Thanks for reporting + patch!

Login to comment on this ticket.

Metadata