I run {{{ fedora-review --rpm-spec --prebuilt --name dnf-plugins-core }}} hoping that '''mock''' won't be used, yet '''mock''' was still started and a chroot was built.
The man page suggests that command in the ''USING KOJI SCRATCH BUILDS'' section.
I'm using fedora-review-0.5.1-1.fc20.noarch.
What happens here is that the pre-built packages are installed in the mock chroot so they can be checked. They are not built in mock, though.
The manpage note for --prebuilt is "When using -n <name>, use prebuilt rpms in current directory instead of building new ones in mock". So, in a way fedora-review does what it's intended to do.
And still not. CheckBuild (which builds the package) has tests to check if mock is available and can handle the situation if it's not. The test TestPackageInstalls which installs the packages in mock has not this test and will thus fail without mock.
Being able to run without mock is a design criteria, so this should be fixed. Note that the overall policy is to use mock if it's available, degrading gracefully if not. So the fix I have in mind will still run mock in this case it is available.
In other words: to use mock to test if the pre-built packages installs is a Good Thing if mock is available. However, fedora-review should not fail as today if it's not.
I'm inclined to close this as not-a-bug, but not before the related issue described here is fixed.
Added fixes to not run mock if it's unavailable (see above) in 88bf5f7. Closing as 'invalid', there is seemingly no not-a-bug resolution available.
Login to comment on this ticket.