#212 Reflect changes in Ruby guidelines regarding Ruby 2.0
Closed: Fixed None Opened 10 years ago by jstribny.

Ruby package guidelines has changed to reflect changes that Ruby 2.0 brings. This patch simply fixes the changes and adds one more check (regarding the %gem_install macro) to FedoraReview.


I made some changes to the patch and I also divided it into three features:

0001-ruby-RubyGems-must-require-ruby-release.patch​[[BR]]
0002-ruby-gem_extdir-is-deprecated-check-for-gem_extdir_mri.patch[[BR]]
0003-ruby-Gem-should-use-gem_install-macro.patch​[[BR]]

I hope it's much more clear now as well as more sophisticated.

Thanks.

We don't really know version of next release. Moving to future

Hi!

Many thanks for these patches! At a first look, all looks good. I have pushed a feature branch issue-212 based on these patches to make it easier to review.

One question: since %gem_extdir now is deprecated, wouldn't be a good idea to search for this macro and issue a warning if it's there?

Hi,

I fixed patch 0003-ruby-Gem-should-use-gem_install-macro.patch​ and added 0004-ruby-Check-for-deprecated-gem_extdir-macro.patch​. Wanted to use the new branch but I couldn't check out the sources. Not sure why.

Replying to [comment:5 jstribny]:

Hi,
Hi, :)

Wanted to use the new branch but I couldn't check out the sources. Not sure why.

Odd. What's the message when you try to checkout the branch?

Sorry, my bad.

All the changes and some new ones are pushed to the issue-212 branch now. I also added a new RubyGem to testing for some Ruby 2.0 guideline tests.

What's the status here? Is this already merged?

All changes merged to devel.

tests seems to run, all commits in placer after git reset. closing after fixes now in d19fc01

Login to comment on this ticket.

Metadata