connection_activity calls connection_make_new_pb and add_pb when there is a new operation, then connection_threadmain calls slapi_pblock_destroy - there is a lot of malloc/free here - once for the slapi_pblock, once for the struct Slapi_PBlock_q used to add it to the queue, and once for the pb_op operation_new - malloc/free is a performance bottleneck as well as a source of thread contention - instead, pre-allocate pblock/operation structures and use a lock-free stack or other lock free structure to hold unused pblocks/operations - use memset to clean the memory when the operation is complete
0003-Ticket-513-recycle-operation-pblocks.patch 0003-Ticket-513-recycle-operation-pblocks.patch
0002-Ticket-513-recycle-operation-pblocks.patch 0002-Ticket-513-recycle-operation-pblocks.patch
Looks good, ack.
commit 20da362 Author: Rich Megginson rmeggins@redhat.com Date: Thu Mar 7 21:10:38 2013 -0700
Metadata Update from @rmeggins: - Issue assigned to rmeggins - Issue set to the milestone: 1.3.2 - 04/13 (April)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/513
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)
Login to comment on this ticket.