It was brought up again: Lets get rid of configure artifacts!
See http://www.port389.org/docs/389ds/design/configure-artifacts.html
attachment 0001-Ticket-49011-Remove-configure-artifacts.patch
This didn't break my CI, srpm/rpm build works! \o/
You have my ack. But I'd like to hear other opinions from devel.
This patch does not apply to master branch. Does "make -f rpm.mk rpms" still work?
It applies cleanly on top of 73b91d8. Next commit (1e1f6fe) introduced changes to configure artifacts, so the patch needs a rebase.
make -f rpm.mk rpms works.
make -f rpm.mk rpms
Replying to [comment:3 vashirov]:
It applies cleanly on top of 73b91d8. Next commit (1e1f6fe) introduced changes to configure artifacts, so the patch needs a rebase. make -f rpm.mk rpms works.
Great. I'll give my ack, but I don't recall who or why there were objections to this. Perhaps this should raised on ldap-devel list before pushing.
I think Rich was the only objector(?). I would still be good just to get the others in the team to ack this just so they know about the build process change at least.
I withdraw my objection.
Update to latest master 0001-Ticket-49011-Remove-configure-artifacts.2.patch
ok for me
commit 577c4c1 Compressing objects: 100% (13/13), done. Writing objects: 100% (13/13), 1.86 KiB | 0 bytes/s, done. Total 13 (delta 9), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git 2e494bc..577c4c1 master -> master
Metadata Update from @vashirov: - Issue assigned to firstyear - Issue set to the milestone: 0.0 NEEDS_TRIAGE
Metadata Update from @vashirov: - Issue set to the milestone: None (was: 0.0 NEEDS_TRIAGE)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/2070
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)
Login to comment on this ticket.