This updates the lib389 specfile to correctly generate python2 and python3 rpms for fedora and rhel. Due to current limitations of python3 in rhel, we don't generate the python34 libraries there, but the tooling is there to change this later.
This also gates the new cli tools to be python3 only, without excluding our tests and libraries from operating in python2
It is not necessary to special case build/test dependencies for rhel and fedora. Fedora packages provides old names. e.g. {{{ sh$ rpm -q --provides python2-pytest pytest = 2.9.2-2.fc25 python-pytest = 2.9.2-2.fc25 python2-pytest = 2.9.2-2.fc25 python2.7dist(pytest) = 2.9.2 }}}
Yes, but I don't want to rely on the oldnames existing: I want to be explicit in my requirements, and what is in the spec. This way when we are able to remove the RHEL7 "hacks", it will be a clean, explicit spec file. So I would rather leave it.
I'll review this tomorrow - it must comply with the fedora packaging guidelines (they are pretty strict sometimes)
https://fedoraproject.org/wiki/Packaging:Python was what I followed to create this, so I hope it should be very close to compliance already. Thanks for your future review,
attachment 0001-Ticket-48991-Fix-lib389-spec-for-python2-and-python3.patch
Ack, but please add a changelog entry for this change to the spec file.
commit deb6d71ed2cb5104874982881e5b518e85738d3f Writing objects: 100% (4/4), 1.56 KiB | 0 bytes/s, done. Total 4 (delta 2), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/lib389.git 5fd2864..deb6d71 master -> master
Add changelog as you asked, thanks for the review!
Metadata Update from @lslebodn: - Issue assigned to firstyear - Issue set to the milestone: lib389 1.0.3
Metadata Update from @mreynolds: - Issue close_status updated to: None (was: Fixed) - Issue set to the milestone: None (was: lib389 1.0.3)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/2050
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix
Login to comment on this ticket.