389-ds-base

Clone
Source Code
GIT

#48979 Allow to compile 389ds with warning Wstrict-prototypes
Closed: wontfix None Opened 7 years ago by lslebodn.

Closed: wontfix
Reopen Issue

freeIPA project compiles C source code with enabled many warnings.
389ds is probably not compiled with this warning and cause issues for freeIPA.

https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org/message/RT3P4INJVBCLXRBPCCKQDZ7KGHV3AG6D/

If you want to test patches then you need to fix prototype in ssl.h
e.g. sed -e 's/()/(void)/' -i /usr/include/nss3/ssl.h
Otherwise there will be bunch of warnings

  CC       ldap/servers/slapd/libslapd_la-attr.lo
In file included from ldap/servers/slapd/slap.h:109:0,
                 from ldap/servers/slapd/attr.c:25:
/usr/include/nss3/ssl.h:364:1: warning: function declaration isn't a prototype -Wstrict-prototypes]
 SSL_IMPORT unsigned int SSL_SignatureMaxCount();
 ^~~~~~~~~~

I will begin to review this for you now.

Squashed and acked version of Lukas' patch.
0001-Ticket-48979-Allow-to-compile-389ds-with-warning-Wst.patch

Fixes for csn and counters.
0002-Ticket-48979-Strict-Prototypes.patch

ack to your 17 patches. I have squashed these to one patch for commit to the repo.

Do you mind checking my extra patch to confirm it's okay before I push that also? Thanks for all your work on this!

PS: I'm running our test suites to be sure, but I expect no issues. I'll push to the repo when they pass.

commit 5b0c9c0
Writing objects: 100% (193/193), 23.58 KiB | 0 bytes/s, done.
Total 193 (delta 169), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
73d74f5..5b0c9c0 master -> master

Pushed Lukas' patch.

Replying to [comment:2 firstyear]:

ack to your 17 patches. I have squashed these to one patch for commit to the repo.

I do not like if somebody touches my patches without a permission :-)

I would be fine with squashing patches 5-12 into one.
But other patches solved different issues and therefore should be in different patches. And moreover 17th patch is very u huge itself and

If you prefer small amount of patches in 389-ds then I would survive two patches. But 17th patch should have been pushed without any change. It was already very huge.

I tried to compile with many various options but I missed "#ifdef DEBUG "

0002-Ticket-48979-Strict-Prototypes.patch​
ACK.

Replying to [comment:4 lslebodn]:

Replying to [comment:2 firstyear]:

ack to your 17 patches. I have squashed these to one patch for commit to the repo.

I do not like if somebody touches my patches without a permission :-)

I would be fine with squashing patches 5-12 into one.
But other patches solved different issues and therefore should be in different patches. And moreover 17th patch is very u huge itself and

If you prefer small amount of patches in 389-ds then I would survive two patches. But 17th patch should have been pushed without any change. It was already very huge.

Sorry, In the past I have done similar (posting many patches) and the team prefers to squash. I completely understand where you are coming from though. For review, the split patches can be nicer depending on the changes. It's already done though, so next time, we'll have to come to some way to make everyone happy.

Ack from Lukas.

commit d46a0f6
Writing objects: 100% (7/7), 819 bytes | 0 bytes/s, done.
Total 7 (delta 5), reused 1 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
5b0c9c0..d46a0f6 master -> master

Metadata Update from @lslebodn:
- Issue set to the milestone: 0.0 NEEDS_TRIAGE
7 years ago

Metadata Update from @vashirov:
- Issue set to the milestone: None (was: 0.0 NEEDS_TRIAGE)
4 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/2038

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: Fixed)
3 years ago

Login to comment on this ticket.

Metadata
None
None
None
None
major
None
ack
None
Community
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.