#48886 lib389: Isses with CA cert detection for nss in tests
Closed: wontfix None Opened 7 years ago by firstyear.

In a clean environment, this exception can be found.

        # Check if ca exists. Should be false.
        assert(topology.standalone.nss_ssl._rsa_ca_exists() is False)
        # Create it. Should work.
        assert(topology.standalone.nss_ssl.create_rsa_ca() is True)
        # Check if ca exists. Should be true
>       assert(topology.standalone.nss_ssl._rsa_ca_exists() is True)
E       assert <bound method NssSsl._rsa_ca_exists of <lib389.nss_ssl.NssSsl object at 0x218b210>>() is True
E        +  where <bound method NssSsl._rsa_ca_exists of <lib389.nss_ssl.NssSsl object at 0x218b210>> = <lib389.nss_ssl.NssSsl object at 0x218b210>._rsa_ca_exists
E        +    where <lib389.nss_ssl.NssSsl object at 0x218b210> = <lib389.DirSrv instance at 0x1fadc68>.nss_ssl
E        +      where <lib389.DirSrv instance at 0x1fadc68> = <tickets.ticket48798_test.TopologyStandalone object at 0x218b450>.standalone

ds/dirsrvtests/tests/tickets/ticket48798_test.py:101: AssertionError

Hi William,
looks like you have some other changes in your dev environment beside the patch.
I see a lot of conflicts with clean cloned repo there.

Steps to reproduce:
1. [root@fed-dev export]# git clone https://git.fedorahosted.org/git/389/lib389.git

{{{
Cloning into 'lib389'...
remote: Counting objects: 970, done.
remote: Compressing objects: 100% (960/960), done.
remote: Total 970 (delta 699), reused 0 (delta 0)
Receiving objects: 100% (970/970), 386.10 KiB | 360.00 KiB/s, done.
Resolving deltas: 100% (699/699), done.
Checking connectivity... done.
}}}

  1. [root@fed-dev lib389]# git am 0001-Ticket-48886-Fix-NSS-SSL-library-in-lib389.patch

{{{
Applying: Ticket 48886 - Fix NSS SSL library in lib389
/export/lib389/.git/rebase-apply/patch:190: trailing whitespace.
# IE ['',
/export/lib389/.git/rebase-apply/patch:191: trailing whitespace.
# 'Certificate Nickname Trust Attributes',
/export/lib389/.git/rebase-apply/patch:192: trailing whitespace.
# ' SSL,S/MIME,JAR/XPI',
/export/lib389/.git/rebase-apply/patch:193: trailing whitespace.
# '',
/export/lib389/.git/rebase-apply/patch:194: trailing whitespace.
# 'Self-Signed-CA CTu,u,u',
error: patch failed: lib389/nss_ssl.py:13
error: lib389/nss_ssl.py: patch does not apply
error: patch failed: lib389/passwd.py:44
error: lib389/passwd.py: patch does not apply
error: patch failed: python-lib389.spec:15
error: python-lib389.spec: patch does not apply
Patch failed at 0001 Ticket 48886 - Fix NSS SSL library in lib389
}}}

This relies on all the pep8 fixes and such .... So they need to be reviewed and merged first. It's a waste of time to bother rebasing this without them, to the have to rebase the pep8 changes again ....

Re-setting this to review, as it should work once pep8 fixes apply.

All tests have passed and code looks good to me.
Beside pep8 fixes(#48878) I've applied spec file fixes(#48885). After that everything went okay.

commit 24f7d8d45a2816c57ba979d36309a66b82c8b980
Writing objects: 100% (61/61), 10.43 KiB | 0 bytes/s, done.
Total 61 (delta 55), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/lib389.git
1c09a99..24f7d8d master -> master

Sorry for the run around on this one :(

Metadata Update from @spichugi:
- Issue assigned to firstyear
- Issue set to the milestone: lib389 1.0.2

7 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/1945

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: Fixed)

3 years ago

Login to comment on this ticket.

Metadata