In some cases it is useful to allow a plugin to change the target_dn before processing the extop. For example an extop targeting a virtual entry allows to translated the virtual entry DN into the proper DN.
attachment 0001-Ticket-48880-RFE-adding-pre-post-extop-ability.patch
Ticket has been cloned to Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1344414
Patch looks great to me. Nice and simple.
What's the use case for it? I would like to have something that consumes both the PRE / POST extop you are adding here to be sure it works.
But a visual look, the patch is correct! I will ack this with the promise you'll come back with something that consumes both.
Hi William,
Thanks for the comments and review. I attached the patch of the 48880 use case and test case (it is only pre-extop but can easily be translated to post-op stuff)
This pre/post extop is required by https://fedorahosted.org/freeipa/ticket/5946 and the schedule being quite limited, I will push the change now.
attachment 0001-ticket-48880-use-case.patch
'''merge''' Updating f650df3..2860907 Fast-forward ldap/servers/slapd/extendop.c | 9 +++++++++ ldap/servers/slapd/pblock.c | 25 ++++++++++++++++++++++++- ldap/servers/slapd/plugin.c | 14 +++++++++++++- ldap/servers/slapd/slap.h | 8 +++++++- ldap/servers/slapd/slapi-plugin.h | 8 ++++++-- 5 files changed, 59 insertions(+), 5 deletions(-)
'''master''' Counting objects: 10, done. Delta compression using up to 8 threads. Compressing objects: 100% (10/10), done. Writing objects: 100% (10/10), 1.76 KiB | 0 bytes/s, done. Total 10 (delta 8), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git f650df3..2860907 master -> master
commit 2860907 Author: Thierry Bordaz tbordaz@redhat.com Date: Thu Jun 9 16:09:12 2016 +0200
Metadata Update from @tbordaz: - Issue set to the milestone: 1.3.5.5
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/1939
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)
Login to comment on this ticket.