#48794 lib389 build requires are on a single line
Closed: wontfix None Opened 7 years ago by firstyear.

Certain scripts don't work with buildrequires: x, y, ....

This should be:

BuildRequires: x
BuildRequires: y


ACK++

But I would like to ask which scripts does not work with BuildRequires on single line.

{{{
grep "^BuildRequires" ds/rpm/389-ds-base.spec.in svrcore/svrcore.spec rest389/python-rest389.spec lib389/python-lib389.spec | awk '{ print $2 }' | grep -v "^/"
}}}

Because the 389-ds-base.spec.in is not a .spec, it cannot be used by yum-builddep. Yes, I could split this into two commands because of the difference, but I wanted a one shot command that works.

As well, it's much neater, and easier to reason about. I think it's better form in the .spec to have them on their own lines too.

commit bf7a554c8c59f608ad986a349d1da6caac34bfe3
Total 4 (delta 3), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/lib389.git
bf57c56..074f3bc master -> master

Replying to [comment:3 firstyear]:

{{{
grep "^BuildRequires" ds/rpm/389-ds-base.spec.in svrcore/svrcore.spec rest389/python-rest389.spec lib389/python-lib389.spec | awk '{ print $2 }' | grep -v "^/"
}}}

I assume you develop on fedora and you can use dnf builddep there. It has option "--spec" which treats arguments as spec files.

Because the 389-ds-base.spec.in is not a .spec, it cannot be used by yum-builddep. Yes, I could split this into two commands because of the difference, but I wanted a one shot command that works.
Simple grep might work in this case but it will not work if condition are used in spec file.
(JFYI)
{{{
%if (0%{?fedora} || (0%{?rhel} >= 7))
BuildRequires: libnfsidmap-devel
%else
BuildRequires: nfs-utils-lib-devel
%endif
}}}

As well, it's much neater, and easier to reason about. I think it's better form in the .spec to have them on their own lines too.

Metadata Update from @firstyear:
- Issue assigned to firstyear
- Issue set to the milestone: lib389 1.0.2

7 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/1854

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: Fixed)

3 years ago

Login to comment on this ticket.

Metadata