#48778 PassSync installer overwrites "Notification Packages" value in registry instead of appending it
Closed: wontfix None Opened 8 years ago by vashirov.

Description of problem:

https://git.fedorahosted.org/cgit/389/winsync.git/tree/passwordsync/wix/PassSync.wxs#n273
            <RegistryKey Id='NotPkgs' Root='HKLM' Key='SYSTEM\ControlSet001\Control\Lsa' ForceCreateOnInstall='yes' >
              <RegistryValue Name='Notification Packages' Type='multiString' Value='passhook'/>
            </RegistryKey>
Here key "Notification Packages" should be *appended* with the new value 'passhook'. But instead installer *replaces* the old values with the new one.

Before the installation of PassSync:
----
C:\Users\Administrator>reg query HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Lsa /v "Notification Packages"

HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Lsa
    Notification Packages    REG_MULTI_SZ    scecli\0rassfm
----

After the installation of PassSync:
----
C:\Users\Administrator>reg query HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Lsa /v "Notification Packages"

HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Lsa
    Notification Packages    REG_MULTI_SZ    passhook
----

And during the uninstallation it removes the key completely (which also should not happen):
----
C:\Users\Administrator>reg query HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Lsa /v "Notification Packages"

ERROR: The system was unable to find the specified registry key or value.
----

Version-Release number of selected component (if applicable):
RedHat-PassSync-1.1.6-x86_64.msi

How reproducible:
always

Steps to Reproduce:
1. Setup Windows 2008R2 with AD
2. Check the value of "Notification Packages"
reg query HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Lsa /v "Notification Packages"
3. Install passsync
4. Check the value of "Notification Packages"
5. Uninstall passsync
6. Check the value of "Notification Packages"

Actual results:
Old value is replaced with "passhook".

Expected results:
Value "passhook" should be appended

Forgot to close it... It's already shipped as RedHat-PassSync-1.1.7-x86_64.msi.

Metadata Update from @vashirov:
- Issue set to the milestone: 389-admin,console 1.1.42

7 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/1838

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: Fixed)

3 years ago

Login to comment on this ticket.

Metadata