attachment
0001-Ticket-48449-Import-readNSState-from-richm-s-repo.patch

Ticket has been cloned to Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1303794

Looks good.

I have 2 requests...
1) license is missing?
2) man page is missing?

Hi William,

Would you push your patch with the license and man page?

Thanks!

attachment
0001-Ticket-48449-Import-readNSState-from-richm-s-repo.2.patch

Hi,

I've updated this import, added the man page, and made some slight tweaks to the python command. Do you mind reviewing before I pull this into the repo?

Sorry for taking this long time to review this ticket...

1) Maybe you need to push Makefile.in (autogen'ed), as well?

2) We usually don't put the full path here, but since the other python scripts depend upon python2, we have no better choice?
{{{

!/usr/bin/python3

}}}

3) What is python34?
{{{
210 %{?rhel:Requires: python34}
}}}

There is no python3 in RHEL7 base OS, it's only available in the Software Collections. Script works fine with python2, so let's stick with it for now.

Uses pythonexec, and works with python2
0001-Ticket-48449-Import-readNSState-from-richm-s-repo.3.patch

Thank you for taking care of my questions.

Your new patch looks good!

commit f650df3

Writing objects: 100% (15/15), 7.88 KiB | 0 bytes/s, done.
Total 15 (delta 10), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
c2bc670..f650df3 master -> master

One line fix. Pushed to master:
2b2f7a8..a2c2bc1 master -> master
commit a2c2bc1

Description: Adding readnsstate.1 to dist_man_MANS in Makefile.{am,in} to install the readnsstate man page as /usr/share/man/man1/readnsstate.1.gz.

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/1771

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.