Our configure script has the current logic:
If systemd: - disable else: - always use initddir
This isn't good form for porting to other distros. initddir should accept ="no" to prevent the creation of /etc/init.d/rc.d scripts.
attachment 0001-Ticket-48447-with-initddir-should-accept-no.patch
A question about this line. 472 AM_CONDITIONAL([INITDDIR], [test -z "$with_initdir" -a "$with_initddir" != "no"])
The length of $with_initdir is 0 AND $with_initdir is not "no"? You may want to check the length with '-n'?
I think you are right. I want to check if it's not no AND has some content. I'll fix this up.
attachment 0001-Ticket-48447-with-initddir-should-accept-no.2.patch
This update, I checked and double check, the logic is correct.
Looks good. Thanks.
commit 5c72fee72abfcb5b2d064eb9a640732317d539b1 Total 6 (delta 5), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git b2022ca..2b38bec master -> master
Metadata Update from @firstyear: - Issue assigned to firstyear - Issue set to the milestone: 1.3.5 backlog
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/1769
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)
Login to comment on this ticket.