attachment
0001-Ticket-48433-Aci-linting-tools.patch

Hi William,
thank you for developing new lib389 features. :) Lint tool code looks good to me. I don't know how useful it will be, but it does what it should.
'''
lib389/tests/aci_lint_test.py''' has some little issues:

{{{
26 standalone = DirSrv(verbose=True)
}}}
I think it would be better to change verbose to False, because True produces a lot of info we don't use very often.

'''aci_parse_test.py''' and '''aci_lint_test.py''' contain the same fixtures. In my opinion, it would be better to have one '''aci_test.py''' test suite with all aci related tests.

Also, of course, it would be better to have more tests with more assertions that will cover existing functionality. If you don't have time now, I will look at it some day later.

Replying to [comment:3 spichugi]:

Hi William,
thank you for developing new lib389 features. :) Lint tool code looks good to me. I don't know how useful it will be, but it does what it should.

I can see it being very useful ;) ACI's are hard to write, so a way to test them is good. I'm essentially "pre-empting" a swap to lib389 for cli tools in the future.

'''
lib389/tests/aci_lint_test.py''' has some little issues:

{{{
26 standalone = DirSrv(verbose=True)
}}}
I think it would be better to change verbose to False, because True produces a lot of info we don't use very often.

I think you are right! I missed this.

'''aci_parse_test.py''' and '''aci_lint_test.py''' contain the same fixtures. In my opinion, it would be better to have one '''aci_test.py''' test suite with all aci related tests.

Also, of course, it would be better to have more tests with more assertions that will cover existing functionality. If you don't have time now, I will look at it some day later.

I don't know how many more assertions would be needed? But if you can see more cases, please add them.

I will merge the two tests as you suggest however, I think it makes sense.

attachment
0001-Ticket-48433-Aci-linting-tools.2.patch

commit 72b3fae6c6c2c11d2e2cef1ea2a97c033e9f011f
Total 9 (delta 5), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/lib389.git
074f3bc..4255e0d master -> master

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/1762

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.