Looks good.

It may not be something to be considered in lib389, but this code may be conflict with the request:
Ticket #48272 - Allow PRE_BIND plugins to mangle DNs
in which it binds with non-DN and the bind value is replaced with DN in a pre plug-in. That may not be a uid - dn relationship.
{{{
945 else:
946 """
947 See if binddn is a dn, or a uid that we need to lookup.
948 Check the configuration suffix(es), and the default suffix
949 """
950 if self.binddn and not is_a_dn(self.binddn):
951 """
952 No DN, but a uid value(?), search for it in the configuration
953 and default suffixes
954 """
955 ent = None
956 self.simple_bind_s("", "") # anonymous
... ...
}}}

Otherwise, you have my ack.

Email conversation with rcrit:

It looks like the only saslmethod support is gssapi. I think I'd
document that in the method header.

Okay I'll add that

What about autobind? Should that be supported as well?

This can be done via a separate ticket - there was no immediate need for it (yet)

Replying to [comment:2 nhosoi]:

Looks good.

It may not be something to be considered in lib389, but this code may be conflict with the request:
Ticket #48272 - Allow PRE_BIND plugins to mangle DNs
in which it binds with non-DN and the bind value is replaced with DN in a pre plug-in. That may not be a uid - dn relationship.

Well this code was part of the original version of lib389 - its not actually being used, and it will conflict with 48272. While it's nice to have, it's not needed. So I will remove it - working on a new patch...

New patch attached...

revision
0001-Ticket-48335-Add-SASL-support-to-lib389.patch

To ssh://git.fedorahosted.org/git/389/lib389.git
82bbdaf..2cbbb75 master -> master
commit 2cbbb75367da1971236592fc6363f5a695bfc550
Author: Mark Reynolds mreynolds@redhat.com
Date: Mon Nov 9 16:13:40 2015 -0500

Milestone lib389 1.0 deleted

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/1666

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.