#48309 Fix lib389 lib imports
Closed: wontfix None Opened 8 years ago by spichugi.

Some lib389 lib imports are declared in a bad way. It causes bugs.

For example, lib389/backend.py contains:

from lib389 import DirSrv, Entry, NoSuchEntryError, InvalidArgumentError
from .__init__ import UnwillingToPerformError

So if you want to catch these exceptions, while using backend.py library, you should declare them only in that way.

It should be changed to something like this:

from lib389 import DirSrv, Entry
from lib389 import NoSuchEntryError, InvalidArgumentError, UnwillingToPerformError

Also, it would be nice to change and group all import to the PEP8 way.

  1. standard library imports
  2. related third party imports
  3. local application/library specific imports

Pushed to ssh://git.fedorahosted.org/git/389/lib389.git

5ce77da..171cfc8 master -> master
commit 171cfc8138cece477a37934794e501507812a8b4
Author: Simon Pichugin spichugi@redhat.com
Date: Tue Oct 13 13:28:27 2015 +0200

Milestone lib389 1.0 deleted

Metadata Update from @spichugi:
- Issue assigned to spichugi

7 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/1640

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: Fixed)

3 years ago

Login to comment on this ticket.

Metadata