Description of problem: If we execute ds-logpipe.py with wrong arguments, then instead of proper message we see AttributeError python exception.
How reproducible: Always
Step to Reproduce: Execute command line utility ds-logpipe.py with a wrong arguments:
ds-logpipe.py wrong_arg1 wrongarg2
Actual results:
Traceback (most recent call last): File "./ldap/admin/src/scripts/ds-logpipe.py", line 263, in <module> options, logfname = parse_options() File "./ldap/admin/src/scripts/ds-logpipe.py", line 259, in parse_options parser.error("error - unhandled command line arguments: %s" % args.join(' ')) AttributeError: 'list' object has no attribute 'join'
Expected results:
Usage: ds-logpipe.py <name of pipe> [options] ds-logpipe.py: error: error - unhandled command line arguments: wrong_arg1 wrongarg2
attachment 0001-Ticket-48302-ds-logpipe.py-with-wrong-arguments-pyth.patch
Looks good to me, I'll merge this for you.
commit 5b606aa1c9fe5e9dd2e9ba4fe956b4fafa11437f
Total 7 (delta 5), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git 22ec6b2..45c7165 master -> master
Metadata Update from @firstyear: - Issue assigned to spichugi - Issue set to the milestone: 1.3.5.0
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/1633
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)
Login to comment on this ticket.