When a "critical" plugin is being modified, like "cn=ldbm database,cn=plugins,cn=config", we should still allow the operation to succeed even though the plugin is not restarted and the changes are not dynamically applied. Instead just log an error stating that a restart might be required for the change to take effect.
This was discovered by installing freeIPA (with dynamic plugins enabled) which adds aci's to "critical" plugins. These updates should not be rejected.
{{{ LDAPDebug(LDAP_DEBUG_ANY, "plugin_restart: Plugin (%s) is critical to server operation. " 2314 "Any changes might not take effect until the server is restarted.\n", }}}
This message is ambiguous. Is there any way we can know for sure if the server needs to be restarted? Otherwise, to be sure, I would just say "Server requires restart for changes to take effect.".
revision 0001-Ticket-48177-dynamic-plugins-should-not-return-an-er.patch
Replying to [comment:2 rmeggins]:
{{{ LDAPDebug(LDAP_DEBUG_ANY, "plugin_restart: Plugin (%s) is critical to server operation. " 2314 "Any changes might not take effect until the server is restarted.\n", }}} This message is ambiguous. Is there any way we can know for sure if the server needs to be restarted? Otherwise, to be sure, I would just say "Server requires restart for changes to take effect.".
Yeah there is no easy way to detect if the attribute being modified is critical to the plugin, or not. So I used your logging suggestion. New patch attached.
947477f..aa0588e master -> master commit aa0588e Author: Mark Reynolds mreynolds@redhat.com Date: Thu Apr 30 15:17:55 2015 -0400
ec8801a..1fe0088 389-ds-base-1.3.3 -> 389-ds-base-1.3.3 commit 1fe0088
Metadata Update from @mreynolds: - Issue assigned to mreynolds - Issue set to the milestone: N/A
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/1508
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)
Login to comment on this ticket.