The public header file should be called "nunc-stans.h". We should remove anything from that public file that is used internally only - ns_alloc and ns_free - #define PR_WOULD_BLOCK - ns_log
I suppose we can use ns_thrpool.h as the private header file
Could you clarify the intended use of "#define PR_WOULD_BLOCK"?
Hmm - it's only used in test-protocol.c, so just move PR_WOULD_BLOCK to test-protocol.c
Also note - I pushed the doxygen changes, which have the header file name hard coded in Makefile.am and possibly other places. Please check everywhere ns_thrpool.h is referenced.
The ns_thread_t stuff and the logging stuff should also be in the private file.
Otherwise, looks good
Replying to [comment:7 rmeggins]:
The ns_thread_t stuff and the logging stuff should also be in the private file. Otherwise, looks good
New patch attached...
Looks like this latest patch is missing ns_private.h?
revision 0001-Ticket-48103-rename-public-header-file-to-nunc-stans.patch
Replying to [comment:9 rmeggins]:
New patch attached
commit f6e3e989ee40e94fe10b621db3969cdb7a56d08f Author: Mark Reynolds mreynolds@redhat.com Date: Fri Mar 6 09:14:17 2015 -0500
DS needs to replace ns_thrpool.h with nunc-stans.h
looks good, but are you missing m4/nunc-stans.m4?
DS patch 0001-Ticket-48103-update-DS-for-new-nunc-stans-header-fil.patch
Replying to [comment:14 rmeggins]:
commit 8950c88d8ba1e4a590def26b36925e4345260751 Author: Mark Reynolds mreynolds@redhat.com Date: Fri Mar 6 11:32:00 2015 -0500
the nunc-stans patch was missing nunc-stans.h
add nunc-stans.h 0001-Ticket-48103-Add-missing-nunc-stans.h.patch
Replying to [comment:19 rmeggins]:
Sorry about that, new patch attached...
commit 89b749124e45fd6692b9a820d32d1ee50c8f939d Author: Mark Reynolds mreynolds@redhat.com Date: Fri Mar 6 12:55:20 2015 -0500
moved to https://fedorahosted.org/nunc-stans/ticket/11
Metadata Update from @rmeggins: - Issue assigned to mreynolds - Issue set to the milestone: 1.3.4 backlog
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/1434
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)
Login to comment on this ticket.