This is more code I thought would be needed, but is unnecessary. Anything related to
struct stack_state *thread_stack; /* stack of ns_thread_t */ PRLock *thread_stack_lock; /* to support ns_thread_acquire/release */ PRCondVar *thread_stack_cv; /* to support ns_thread_acquire/release */
in ns_thrpool_t, and thread_stack_wait() and thread_stack_notify()
attachment 0001-Ticket-48045-get-rid-of-thread_stack-code.patch
get rid of thread_stack too
Replying to [comment:3 rmeggins]:
I did, but then valgrind reported memory leaks around the worker threads(PR_CreateThread) so I brought it back in. Keeping the stack in place didn't seem to cause any extra overhead, and it resolved the memory leak.
Replying to [comment:4 mreynolds]:
Replying to [comment:3 rmeggins]: get rid of thread_stack too I did, but then valgrind reported memory leaks around the worker threads(PR_CreateThread) so I brought it back in. Keeping the stack in place didn't seem to cause any extra overhead, and it resolved the memory leak.
yeah, sorry - can't get rid of thread_stack - ack
commit c80eea54bb36cfbd629593e8e9a48b4254cb4017
moved to https://fedorahosted.org/nunc-stans/ticket/8
Metadata Update from @mreynolds: - Issue assigned to mreynolds - Issue set to the milestone: 1.3.4 backlog
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/1376
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)
Login to comment on this ticket.