#48029 lib389 - complete unfinished replica functions
Closed: wontfix None Opened 9 years ago by mreynolds.

There are several functions in replica.py that were not finished/fully implemented. E.g. delete(), disableReplication(), etc.


Hi Mark,

Regarding Agreements.delete, you are doing a search to retrieve the agreement matching a suffix/consumer.
I wonder if you could use agreements.list() to retrieve them/it ?

Same remark for Replica.delete, you may retrieve all the agreements using agreements.list(replica.suffix)

Replying to [comment:2 tbordaz]:

Hi Mark,

Regarding Agreements.delete, you are doing a search to retrieve the agreement matching a suffix/consumer.
I wonder if you could use agreements.list() to retrieve them/it ?

Same remark for Replica.delete, you may retrieve all the agreements using agreements.list(replica.suffix)

I'll look into it. Currently "list" will not find any windows replication agreements, but I can work on that.

Thanks!

Replying to [comment:3 mreynolds]:

Replying to [comment:2 tbordaz]:

Hi Mark,

Regarding Agreements.delete, you are doing a search to retrieve the agreement matching a suffix/consumer.
I wonder if you could use agreements.list() to retrieve them/it ?

Done, new patch attached for review.

That looks very good. Thanks Mark.

To ssh://git.fedorahosted.org/git/389/lib389.git
6a733eb..16aaaeb master -> master
commit 16aaaeb59af1f2eac2b13011ce3ff0a509d00fb3
Author: Mark Reynolds mreynolds@redhat.com
Date: Mon Feb 16 16:23:23 2015 -0500

Milestone lib389 1.0 deleted

Metadata Update from @mreynolds:
- Issue assigned to mreynolds

7 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/1360

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: Fixed)

3 years ago

Login to comment on this ticket.

Metadata