FreeIPA compilation gives a GCC warning in a 389-ds header:
In file included from ipa_dns.c:54:0: /usr/include/dirsrv/slapi-plugin.h:5585:1: warning: function declaration isn't a prototype [-Wstrict-prototypes] int slapi_td_plugin_lock_init(); ^
Here is the fix
diff --git a/ldap/servers/slapd/slapi-plugin.h b/ldap/servers/slapd/slapi-plugin.h index f1ecfe8..268e465 100644 --- a/ldap/servers/slapd/slapi-plugin.h +++ b/ldap/servers/slapd/slapi-plugin.h @@ -5582,7 +5582,7 @@ void slapi_td_get_val(int indexType, void **value); int slapi_td_dn_init(void); int slapi_td_set_dn(char *dn); void slapi_td_get_dn(char **dn); -int slapi_td_plugin_lock_init(); +int slapi_td_plugin_lock_init(void); int slapi_td_set_plugin_locked(int *value); void slapi_td_get_plugin_locked(int **value); --
attachment 0001-Ticket-47899-Fix-slapi_td_plugin_lock_init-prototype.patch
Thanks to Petr Viktorin for providing the patch. I reviewed it.
Pushed to git repository on behalf of Petr.
master: cb17381..3104346 master -> master commit 3104346
389-ds-base-1.3.3: 1729443..e7a26dd 389-ds-base-1.3.3 -> 389-ds-base-1.3.3 commit e7a26dd
Metadata Update from @nhosoi: - Issue assigned to nhosoi - Issue set to the milestone: 1.3.3 - 10/31 (October)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/1230
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)
Login to comment on this ticket.