3. Defect type: CLANG_WARNING ¶ 1. 389-ds-base-1.2.11.15/ldap/servers/slapd/tools/rsearch/nametable.c:161:5:warning – Potential leak of memory pointed to by 's' # PR_Close(fd); # ^~~~~~~~ 4. Defect type: CLANG_WARNING 1. 389-ds-base-1.2.11.15/ldap/servers/slapd/tools/migratecred.c:164:8:warning – Potential leak of memory pointed to by 'prefixCred' # if ( !oldpath || !newpath || !cred ) # ^~~~~~~
git patch file (master) 0001-Ticket-47890-minor-memory-leaks-in-utilities.patch
Looks good, but I don't think you need the NULL check before each free anymore.
git patch file (master) -- revised based upon the review by Mark. Thanks! 0001-Ticket-47890-minor-memory-leaks-in-utilities.2.patch
Pushed to master: 7db4fa9..1279f0e master -> master commit 1279f0e
Pushed to 389-ds-base-1.3.3: 78fdd61..aa8ff4b 389-ds-base-1.3.3 -> 389-ds-base-1.3.3 commit aa8ff4b
Metadata Update from @nhosoi: - Issue assigned to nhosoi - Issue set to the milestone: 1.3.3 - 8/14 (August)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/1221
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)
Login to comment on this ticket.