when running the ipa test suite there are many errors like:
SLAPI_PLUGIN_BE_TXN_POST_DELETE_FN plugin returned error code -1
The messages are caused by the usn postop plugins when an attempt was made to delete a non existing entry. In that case an ldap error (32) is set in the pblocj and the plugin checks this and return. Since the plugin detects that nothing i sto do and the error code is already present, the plugin executes correctly and should return success instead of failure. The message is only logged for deletes because in the other operation the messsages are only logged if TRACE level is set
Hi Ludwig, could you set the milestone? Thanks!
attachment 0001-Ticket-47732-ds-logs-many-SLAPI_PLUGIN_BE_TXN_POST_D.patch
{{{
1091 1091 if (plugin_call_plugins(pb, SLAPI_PLUGIN_BE_TXN_POST_DELETE_FN)) { 1092 LDAPDebug0Args( LDAP_DEBUG_ANY, "SLAPI_PLUGIN_BE_TXN_POST_DELETE_FN plugin " 1092 LDAPDebug0Args( LDAP_DEBUG_TRACE, "SLAPI_PLUGIN_BE_TXN_POST_DELETE_FN plugin " }}} What is the rationale for this? Will the BE_TXN_POST_DELETE plugin always log the actual failure, so we don't have to do it in the backend code?
The reason is to align it with the _add, _modify and _modrdn functions where it is only logged at TRACE level, if no result code is set there is another log message at ANY level
Replying to [comment:5 lkrispen]:
Ah, ok. Thanks. Ack.
$ git merge ticket47732 Updating a7ac181..71a120d Fast-forward ldap/servers/plugins/usn/usn.c | 10 ++++++---- ldap/servers/slapd/back-ldbm/ldbm_delete.c | 4 ++-- 2 files changed, 8 insertions(+), 6 deletions(-) $ git push origin master Counting objects: 19, done. Delta compression using up to 4 threads. Compressing objects: 100% (10/10), done. Writing objects: 100% (10/10), 1.18 KiB, done. Total 10 (delta 7), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git a7ac181..71a120d master -> master
$ git cherry-pick 71a120d [389-ds-base-1.3.2 e21aada] Ticket 47732 - ds logs many "SLAPI_PLUGIN_BE_TXN_POST_DELETE_FN plugin returned error" messages 2 files changed, 8 insertions(+), 6 deletions(-) $ git push origin 389-ds-base-1.3.2 Counting objects: 19, done. Delta compression using up to 4 threads. Compressing objects: 100% (10/10), done. Writing objects: 100% (10/10), 1.18 KiB, done. Total 10 (delta 7), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git c05e9c4..e21aada 389-ds-base-1.3.2 -> 389-ds-base-1.3.2
Ticket has been cloned to Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1118074
Metadata Update from @lkrispen: - Issue assigned to lkrispen - Issue set to the milestone: 1.3.3 - 3/14 (March)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/1065
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)
Login to comment on this ticket.