Environment variables (except TERM and LANG) are ignored if a program is started via service.
If it is started with systemctl, it takes this COMMAND and the values are correctly passed to the server. systemctl set-environment SLAPD_MXFAST=0 MALLOC_TRIM_THRESHOLD_=4096
But to control them explicitly and to provide the same instructions to the service and systemctl, it'd be good to have some variables (proposing SLAPD_MXFAST, MALLOC_TRIM_THRESHOLD_, and MALLOC_MMAP_THRESHOLD_) configurable.
git patch file (master) 0001-Ticket-47693-Environment-variables-are-not-passed-wh.patch
In the config set functions, the error message still refers to password grace limit.
The formatting is off for some of the slapi_log_error calls.
Please change int trim_threashold; to int trim_threshold;
Otherwise, looks good.
git patch file (master; take 2) -- fixed typos and copy & paste leftover... 0001-Ticket-47693-Environment-variables-are-not-passed-wh.2.patch
Thank you, Rich! Fixed the typos and copy & paste errors. (I even forgot to remove my debug print... :( )
Reviewed by Rich (Thank you!!)
Pushed to master: 332e36b..02169ef master -> master commit 02169ef
Pushed to 389-ds-base-1.3.2: e385eb6..476a193 389-ds-base-1.3.2 -> 389-ds-base-1.3.2 commit 476a193
Pushed to 389-ds-base-1.3.1: c96ed68..ae2e7f4 389-ds-base-1.3.1 -> 389-ds-base-1.3.1 commit ae2e7f4
Pushed to 389-ds-base-1.2.11: fd065f1..57199b3 389-ds-base-1.2.11 -> 389-ds-base-1.2.11 commit 57199b3
Ticket has been cloned to Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1109377
Ticket has been cloned to Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1111403
Metadata Update from @nhosoi: - Issue assigned to nhosoi - Issue set to the milestone: 1.2.11.26
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/1029
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)
Login to comment on this ticket.