1) slapi_entry_attr_get_bool only handles "true"/"false" and "yes"/"no" - should be extended to handle "on"/"off"
2) slapi_entry_attr_get_bool should return a given default value when the attribute is not present - right now it returns 0 (false) if attribute is not present
PRBool slapi_entry_attr_get_bool_ext(const Slapi_Entry e, const char type, PRBool default);
What about handling "0" and "1"?
Replying to [comment:1 nkinder]:
ack
slapi_entry_attr_get_bool already supports "on"/"off" and 0/non-zero.
Description: Adding an API slapi_entry_attr_get_bool_ext, which is an extension of slapi_entry_attr_get_bool. The difference is slapi_ entry_attr_get_bool_ext returns the given default value if the type is not found in the entry.
git patch file (master) 0001-Ticket-47608-change-slapi_entry_attr_get_bool-to-han.patch
Reviewed by Rich (Thank you!!)
Pushed to master: 59941ea..57af562 master -> master commit 57af562
Metadata Update from @nkinder: - Issue assigned to nhosoi - Issue set to the milestone: 1.3.3 - 1/14 (January)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/945
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)
Login to comment on this ticket.