Your patch looks good to me.

I have one request -- logging the successfully set var, value pairs in the error log. The TASK_SYSCONFIG_FILE_ATTR file could be manually updated any time and we could lose what values are currently set. We could add getenv task. But I guess that's an overkill... ;)

Replying to [comment:5 nhosoi]:

Your patch looks good to me.

I have one request -- logging the successfully set var, value pairs in the error log.

Any particular log level (TRACE or CONFIG), or default logging? I don't know if we should log it by default though.

The TASK_SYSCONFIG_FILE_ATTR file could be manually updated any time and we could lose what values are > currently set. We could add getenv task. But I guess that's an overkill... ;)

I'm not sure what you are concerned about here. Could you elaborate please? Thanks!

Replying to [comment:5 nhosoi]:

Your patch looks good to me.

I have one request -- logging the successfully set var, value pairs in the error log. The TASK_SYSCONFIG_FILE_ATTR file could be manually updated any time and we could lose what values are currently set. We could add getenv task. But I guess that's an overkill... ;)

I added a new attribute to say if the changes should be logged or not. I do have a check that if setenv fails, it reports an error and quits. So there is no need to do a getenv after the setenv.

New patch attached.

A user could add an environment variable of the form
{{{
export FOO=bar
}}}
to /etc/sysconfig/dirsrv or /etc/sysconfig/dirsrv-INSTANCE. In a sysvinit/service system, these files can be parsed as bash.

Replying to [comment:8 rmeggins]:

A user could add an environment variable of the form
{{{
export FOO=bar
}}}
to /etc/sysconfig/dirsrv or /etc/sysconfig/dirsrv-INSTANCE. In a sysvinit/service system, these files can be parsed as bash.

Added support for:

VARIABLE=value
export VARIABLE=value
setenv VARIABLE value
unsetenv VARIABLE

New patch attached.

Replying to [comment:9 mreynolds]:

Replying to [comment:8 rmeggins]:

A user could add an environment variable of the form
{{{
export FOO=bar
}}}
to /etc/sysconfig/dirsrv or /etc/sysconfig/dirsrv-INSTANCE. In a sysvinit/service system, these files can be parsed as bash.

Added support for:

VARIABLE=value
export VARIABLE=value
setenv VARIABLE value
unsetenv VARIABLE

New patch attached.

I need to add support of "set" and "unset", new patch will be attached shortly...

revision
0001-Ticket-47453-configure-SASL-GSSAPI-Kerberos-without-.patch

Replying to [comment:10 mreynolds]:

Replying to [comment:9 mreynolds]:

Replying to [comment:8 rmeggins]:

A user could add an environment variable of the form
{{{
export FOO=bar
}}}
to /etc/sysconfig/dirsrv or /etc/sysconfig/dirsrv-INSTANCE. In a sysvinit/service system, these files can be parsed as bash.

Added support for:

VARIABLE=value
export VARIABLE=value
setenv VARIABLE value
unsetenv VARIABLE

New patch attached.

I need to add support of "set" and "unset", new patch will be attached shortly...

New patch is attached...

git merge ticket47453
Updating bb4f0c4..681be0d
Fast-forward
ldap/servers/slapd/task.c | 192 +++++++++++++++++++++++++++++++++++++++++++++
1 files changed, 192 insertions(+), 0 deletions(-)

git push origin master
bb4f0c4..681be0d master -> master

commit 681be0d
Author: Mark Reynolds mreynolds@redhat.com
Date: Tue Feb 18 13:52:19 2014 -0500

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/790

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.