#47420 An upgrade script 80upgradednformat.pl fails to handle a server instance name incuding '-'
Closed: wontfix None Opened 10 years ago by nhosoi.

If a server instance name contains '-', e.g., slapd-TEST-SERVER, it accidentally picks up the first part of the instance name 'TEST'.

80upgradednformat.pl needs to be modified as follows:

  • my ($slapd, $serverID) = split(/-/, $instancedir);

  • my ($slapd, $serverID) = split(/-/, $instancedir, 2);


Bug description: If a server instance name contains '-', e.g.,
slapd-TEST-SERVER, it accidentally picks up the first part of
the instance name 'TEST'.

Fix description: Replacing "split(/-/, $instancedir)" with
"split(/-/, $instancedir, 2)".

Do we have the same problem elsewhere in our perl code?

Replying to [comment:2 rmeggins]:

Do we have the same problem elsewhere in our perl code?

Thanks for the ack, Rich!

It looks this is the only place that has the problem...

Pushed to master: commit 4df4aad
Pushed to 389-ds-base-1.3.1: commit 2e3a1c2

Metadata Update from @nhosoi:
- Issue assigned to nhosoi
- Issue set to the milestone: 1.3.1.3

7 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/757

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: Fixed)

3 years ago

Login to comment on this ticket.

Metadata