389 should use ldap_set_option(ld, LDAP_OPT_X_SASL_NOCANON, LDAP_OPT_ON) for outgoing ldap connections. This option should also be configurable via a configuration attribute, with the value of "on" by default.
http://ssimo.org/blog/id_015.html
attachment 0001-Ticket-47317-should-set-LDAP_OPT_X_SASL_NOCANON-to-L.patch
May I ask to change the indentation as little as possible? It's hard to catch the real fix... :(
And (I also did it before :p, but) can we make this type of fix separated, and attach the patch into the ticket 205 (snmp counters index strings for multiple network interfaces with ip addr and tcp port pairs)? Also did code cleanup of slapi_ldap_init_ext(), and fixed a compiler warning in config_set_snmp_index().
It'd make the release effort much lighter... Thanks in advance.
Other than that, your fix looks good to me.
Replying to [comment:4 nhosoi]:
I'm sorry, I know it makes it hard to read. The function itself was hard to read before I fixed the indentation, but I know it then makes reviewing a fix much more tedious. Figured it was the lesser of two evils :-)
And (I also did it before :p, but) can we make this type of fix separated, and attach the patch into the ticket 205 (snmp counters index strings for multiple network interfaces with ip addr and tcp port pairs)?
Of course.
Also did code cleanup of slapi_ldap_init_ext(), and fixed a compiler warning in config_set_snmp_index(). It'd make the release effort much lighter... Thanks in advance.
Also did code cleanup of slapi_ldap_init_ext(), and fixed a compiler warning in config_set_snmp_index().
No problem. I'll try and separate code cleanup into a different patch next time.
git merge ticket47317 Updating 1cbd6d8..7c8c32e Fast-forward ldap/servers/slapd/ldaputil.c | 377 ++++++++++++++++++++------------------- ldap/servers/slapd/libglobs.c | 35 ++++- ldap/servers/slapd/proto-slap.h | 3 + ldap/servers/slapd/slap.h | 2 + 4 files changed, 228 insertions(+), 189 deletions(-)
git push origin master Counting objects: 17, done. Delta compression using up to 4 threads. Compressing objects: 100% (9/9), done. Writing objects: 100% (9/9), 2.52 KiB, done. Total 9 (delta 7), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git 1cbd6d8..7c8c32e master -> master
commit 7c8c32e
fixed typo in config init 0001-Ticket-47317-should-set-LDAP_OPT_X_SASL_NOCANON-to-L.2.patch
Ticket has been cloned to Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1044134
Metadata Update from @nkinder: - Issue assigned to mreynolds - Issue set to the milestone: 1.3.2 - 04/13 (April)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/654
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)
Login to comment on this ticket.