#345 db deadlock return should not log error
Closed: wontfix None Opened 11 years ago by rmeggins.

When entryrdn gets a deadlock, it should not report an error at the default log level e.g.

[15/Apr/2012:07:33:33 -0400] entryrdn-index - _entryrdn_put_data: Adding the
parent link (P28354) failed: DB_LOCK_DEADLOCK: Locker killed to resolve a
deadlock (-30994)

It should log this at the TRACE log level.


Fix description: error log level is set to SLAPI_LOG_TRACE if
DB_LOCK_DEADLOCK is returned from the BDB operations, otherwise
set to SLAPI_LOG_FATAL.

Fix description:
1) In the ldbm_entryrdn.c, error log level is set to
SLAPI_LOG_BACKLDBM if DB_LOCK_DEADLOCK is returned
from the BDB operations, otherwise set to SLAPI_LOG_FATAL.
2) If DB_LOCK_DEADLOCK is returned in the entryrdn functions,
retry the BDB operations up to RETRY_TIMES.
3) The log level of ACLSUMMARY and the one of BACKLDBM were
confused. It was fixed in log.c.

Reviewed by Rich (Thank you!!)

Pushed to master.

$ git merge trac345
Updating 23c0889..dd65701
Fast-forward
ldap/servers/slapd/back-ldbm/ldbm_entryrdn.c | 523 +++++++++++++++++--------
ldap/servers/slapd/log.c | 2 +-
ldap/servers/slapd/slapi-plugin.h | 2 +-
3 files changed, 357 insertions(+), 170 deletions(-)

$ git push
Counting objects: 17, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (9/9), done.
Writing objects: 100% (9/9), 2.60 KiB, done.
Total 9 (delta 7), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
23c0889..dd65701 master -> master

I've opened a ticket regarding the random length delay...

Ticket #350 - To investigate random length delay in the backend

Added initial screened field value.

Metadata Update from @nhosoi:
- Issue assigned to nhosoi
- Issue set to the milestone: 1.2.11.4

7 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/345

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: Fixed)

3 years ago

Login to comment on this ticket.

Metadata