instead of the original approach for ticket#111 which required extensive changes to all of the plugins, use thread local storage to keep track of the original connection DN for use in all subsequent triggered operations for the modifiersName and creatorsName.
The easy to read diff without all the makefile changes easy-to-read-diff.txt
When you set a new value, you need to first get and free the old value
Hi Rich,
Actually the destructor function is always called when you do a "set". I do have a destructor function set which does the free, so I'm fine.
I will also fix the spacing issues in thread_data.c
attachment 0001-Ticket-302-use-thread-local-storage-for-internalModi.patch
Recap from ticket 111
to enable plugin bind dn tracking add this line to "cn=config"
nsslapd-plugin-binddn-tracking: on
Modiersname/creatorsname will now be the bind dn that initiated the operation, and internalModifersName/internalCreatorsName will be the dn of the plugin, or it will be the original bind dn if there was no plugin involved in the operation.
attachment 0001-Schema-Reload-crash-fix.patch
[schema-reload 6bf6e79] Schema Reload crash fix 1 files changed, 8 insertions(+), 0 deletions(-) [mareynol@localhost ds]$ git rebase master Current branch schema-reload is up to date. [mareynol@localhost ds]$ git checkout master Switched to branch 'master' [mareynol@localhost ds]$ git merge schema-reload Updating 60b2d12..6bf6e79 Fast-forward ldap/servers/plugins/schema_reload/schema_reload.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-)
[mareynol@localhost ds]$ git push origin master Counting objects: 13, done. Delta compression using up to 4 threads. Compressing objects: 100% (6/6), done. Writing objects: 100% (7/7), 703 bytes, done. Total 7 (delta 4), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git 60b2d12..6bf6e79 master -> master
re-ack
config needs to ignore the new attributes 0001-Config-changes-fail-because-of-unknown-attribute-int.patch
Added initial screened field value.
This ticket has been amended by ticket 495
Metadata Update from @mreynolds: - Issue assigned to mreynolds - Issue set to the milestone: 1.2.11.a1
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/302
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)
Login to comment on this ticket.