https://bugzilla.redhat.com/show_bug.cgi?id=523783
batch update moving tickets to future
set default ticket origin to Community
Added initial screened field value.
attachment 0001-Ticket-208-RFE-Roles-with-explicit-scoping-in-RHDS.patch
attachment 0001-Ticket-208-RFE-Roles-with-explicit-scoping-in-RHDS.2.patch
A minor request ...
Instead of using strcasecmp, 1181 if (strcasecmp(slapi_sdn_get_dn((const Slapi_DN ) top_rolescopeSDN), 1182 slapi_sdn_get_dn((const Slapi_DN ) top_this_roleSDN)) == 0) { can we use this this api? slapi_sdn_compare( const Slapi_DN sdn1, const Slapi_DN sdn2 )
Other than that, your patch looks good.
attachment 0002-Ticket-208-RFE-Roles-with-explicit-scoping-in-RHDS.patch
Thanks Noriko for the review. I did the recommended changes (thanks for the tips)
git merge ticket208 Updating 33da858..839c46c Fast-forward ldap/schema/02common.ldif | 3 ++- ldap/servers/plugins/roles/roles_cache.c | 58 +++++++++++++++++++++++++++++++++++++++++++++++++++------- ldap/servers/plugins/roles/roles_cache.h | 2 ++ 3 files changed, 55 insertions(+), 8 deletions(-)
git push origin master Counting objects: 19, done. Delta compression using up to 4 threads. Compressing objects: 100% (10/10), done. Writing objects: 100% (10/10), 2.40 KiB, done. Total 10 (delta 7), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git 33da858..839c46c master -> master
commit 839c46c Author: Thierry bordaz (tbordaz) tbordaz@redhat.com Date: Fri Jun 28 14:30:59 2013 +0200
Metadata Update from @tbordaz: - Issue assigned to tbordaz - Issue set to the milestone: 1.3.2 - 08/13 (August)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/208
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)
Login to comment on this ticket.