https://bugzilla.redhat.com/show_bug.cgi?id=213301
Description of problem: Bugzilla Bug 199923: subtree search fails to find items under a db containing special characters (In reply to comment #11) > That's what Slapi_DN is supposed to do - normalize once, and be able to get > normalized and "raw" DN where needed. We should use Slapi_DN as much as > possible. We might want to schedule some time to do some much needed API > revisions to eliminate the use of char *dn in favor of Slapi_DN *dn. But not > for 7.2. In one operation, substr_dn_normalize could be called multiple times against the same dn). We should avoid it.
Some of the work has already been done in 1.2.10
git patch file (master) 0001-Trac-Ticket-139-eliminate-the-use-of-char-dn-in-favo.patch
With the patch applied, the slapi_dn_normalize_ext count called in the start-up 8682 (times) was lowered to 1113 (times).
Reviewed by Rich (Thank you!!!)
Pushed to master.
$ git merge trac139 Updating 9760c1c..04dd396 Fast-forward ldap/servers/plugins/acctpolicy/acct_config.c | 2 +- ldap/servers/plugins/acctpolicy/acct_plugin.c | 2 +- ldap/servers/plugins/acl/acleffectiverights.c | 2 +- ldap/servers/plugins/acl/aclinit.c | 2 +- ldap/servers/plugins/automember/automember.c | 6 ++-- ldap/servers/plugins/dna/dna.c | 15 +++++--- ldap/servers/plugins/linkedattrs/fixup_task.c | 4 +- ldap/servers/plugins/linkedattrs/linked_attrs.c | 2 +- ldap/servers/plugins/memberof/memberof.c | 38 +++++++++++----------- ldap/servers/plugins/mep/mep.c | 12 +++--- ldap/servers/plugins/referint/referint.c | 4 +- ldap/servers/plugins/replication/repl5_replica.c | 2 +- ldap/servers/slapd/config.c | 2 +- ldap/servers/slapd/dn.c | 2 +- ldap/servers/slapd/fedse.c | 14 ++++---- ldap/servers/slapd/main.c | 2 +- ldap/servers/slapd/mapping_tree.c | 6 ++-- ldap/servers/slapd/plugin.c | 4 +- ldap/servers/slapd/plugin_internal_op.c | 4 +- ldap/servers/slapd/schema.c | 2 +- ldap/servers/slapd/snmp_collator.c | 2 +- 21 files changed, 66 insertions(+), 63 deletions(-)
$ git push Counting objects: 71, done. Delta compression using up to 4 threads. Compressing objects: 100% (36/36), done. Writing objects: 100% (36/36), 3.58 KiB, done. Total 36 (delta 29), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git 9760c1c..04dd396 master -> master
No good way to verify this bug... (just performance gain)
Added initial screened field value.
Metadata Update from @nhosoi: - Issue assigned to nhosoi - Issue set to the milestone: 1.2.10.rc1
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/139
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)
Login to comment on this ticket.