#1391 Remove spaces after comment delimiters in the example config file
Closed: wontfix 4 years ago by pbrezina. Opened 11 years ago by sgallagh.

https://bugzilla.redhat.com/show_bug.cgi?id=835073 (Red Hat Enterprise Linux 6)

Description of problem:
The sss daemon which uses the same configuration file can be started without
any parse issues; that is - this is more of a inconsistency problem than a bug.

Also, note that the default sssd.conf file contains configuration directives
preceded with whitespace characters. so this fails by default.


Version-Release number of selected component (if applicable):
sssd-1.8.0-32.el6.x86_64
sssd-client-1.8.0-32.el6.x86_64
sssd-tools-1.8.0-32.el6.x86_64


How reproducible:
always


Steps to Reproduce:
1. run sss_obfuscate --domain <domain> <<< <password>

or

1. edit /etc/sssd/sssd.conf
2. add a preceding whitespace to any not-commented configuration line
3. run sss_obfuscate --domain <domain> <<< <password>

Actual results:
Traceback (most recent call last):
  File "/usr/sbin/sss_obfuscate", line 117, in <module>
    ret = main()
  File "/usr/sbin/sss_obfuscate", line 84, in main
    sssdconfig.import_config(options.filename)
  File "/usr/lib/python2.6/site-packages/SSSDConfig.py", line 1213, in
import_config
    raise ParsingError
SSSDConfig.ParsingError


Expected results:
No output, return code 0 and obfuscated password inserted into the
configuration file.


Additional info:

The problem seems to be the regex pattern on line 496 in ipachangeconf.py:
    OPTCRE = re.compile(
            r'(?P<option>[^:=\s][^:=]*)'          # very permissive!
            r'\s*=\s*'                            # any number of space/tab,
                                                  # followed by separator
                                                  # followed by any # space/tab
            r'(?P<value>.*)$'                     # everything up to eol
            )



Allowing any number of preceding whitespaces seems to fix the issue:
    OPTCRE = re.compile(
            r'\s*(?P<option>[^:=\s][^:=]*)'       # very permissive!
            r'\s*=\s*'                            # any number of space/tab,
                                                  # followed by separator
                                                  # followed by any # space/tab
            r'(?P<value>.*)$'                     # everything up to eol
            )

Fields changed

blockedby: =>
blocking: =>
coverity: =>
feature_milestone: =>
keywords: => easyfix
tests: => 0
testsupdated: => 0
upgrade: => 0

Fields changed

milestone: NEEDS_TRIAGE => SSSD Deferred

Metadata Update from @sgallagh:
- Issue set to the milestone: SSSD Patches welcome

7 years ago

Metadata Update from @jhrozek:
- Custom field patch reset (from 0)
- Custom field testsupdated reset (from 0)
- Issue close_status updated to: None
- Issue tagged with: easyfix

6 years ago

Thank you for taking time to submit this request for SSSD. Unfortunately this issue was not given priority and the team lacks the capacity to work on it at this time.

Given that we are unable to fulfill this request I am closing the issue as wontfix.

If the issue still persist on recent SSSD you can request re-consideration of this decision by reopening this issue. Please provide additional technical details about its importance to you.

Thank you for understanding.

Metadata Update from @pbrezina:
- Issue close_status updated to: wontfix
- Issue status updated to: Closed (was: Open)

4 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/2433

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata